Re: [patch] mm: bug in set_page_dirty_buffers

[Andrew Morton <akpm@osdl.org>]

On Tue, 10 Oct 2006 08:52:17 +0200
Nick Piggin <npiggin@suse.de> wrote:

> On Tue, Oct 10, 2006 at 08:39:00AM +0200, Nick Piggin wrote:
> > As far as set_page_dirty races goes, I am having a bit of a look at that,
> > but it would still require filesystems people to have a look.
> 
> I'm thinking something along the lines of this (untested) patch.

ho hum.

>  void block_invalidatepage(struct page *page, unsigned long offset)
>  {
> -	struct address_space *mapping;
> +	struct address_space *mapping = page->mapping;
>  	struct buffer_head *head, *bh, *next;
> -	unsigned int curr_off = 0;
> +	unsigned int curr_off;
>  
>  	BUG_ON(!PageLocked(page));
> -	spin_lock(&mapping->private_lock);

block_invalidatepage() doesn't take ->private_lock.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>