From: Christoph Hellwig <hch@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
akpm@osdl.org, linux-fsdevel@vger.kernel.org, torvalds@osdl.org
Subject: Re: fscache review comments, part 1
Date: Tue, 10 Oct 2006 14:31:03 +0100 [thread overview]
Message-ID: <20061010133103.GA31268@infradead.org> (raw)
In-Reply-To: <12599.1160401600@redhat.com>
On Mon, Oct 09, 2006 at 02:46:40PM +0100, David Howells wrote:
> Christoph Hellwig <hch@infradead.org> wrote:
>
> > 05-release-page.diff:
> > ACK, though I'd wish someone could come up with nicer names for
> > read_cache_pages_invalidate_page(s).
>
> They could always be nested:-). That way they don't pollute the namespace.
> This is one of the gcc extensions. If you do nm on the output, you see the
> nested function appear like this if not inlined:
>
> 000000000000058f t invalidate_page.17245
>
> That above derives from this:
This is C, not pascal - please don't do such fugly things..
prev parent reply other threads:[~2006-10-10 13:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 16:45 fscache review comments, part 1 Christoph Hellwig
2006-09-28 17:30 ` Andreas Dilger
2006-09-29 0:02 ` Christoph Hellwig
2006-09-29 1:51 ` Timothy Shimmin
2006-09-29 8:38 ` David Howells
2006-10-02 13:40 ` David Howells
2006-10-02 17:39 ` Andrew Morton
2006-10-02 21:41 ` Christoph Hellwig
2006-10-04 13:44 ` Al Viro
2006-10-04 14:18 ` 64-bit inode number issues David Howells
2006-10-04 14:23 ` David Howells
2006-10-08 2:00 ` Theodore Tso
2006-10-08 16:02 ` Alexander Viro
2006-10-07 21:01 ` Christoph Hellwig
2006-10-09 7:58 ` David Howells
2006-10-09 9:01 ` David Chinner
2006-10-09 11:32 ` David Howells
2006-10-09 14:12 ` Arjan van de Ven
2006-10-09 23:53 ` David Chinner
2006-10-12 18:32 ` Benjamin LaHaise
2006-10-17 6:02 ` Chris Wedgwood
2006-10-09 13:46 ` fscache review comments, part 1 David Howells
2006-10-10 13:31 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061010133103.GA31268@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.