From: Ingo Oeser <netdev@axxeo.de>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
jgarzik@pobox.com, akpm@osdl.org, mingo@elte.hu
Subject: Re: [patch 2/2] round_jiffies users
Date: Tue, 10 Oct 2006 18:47:39 +0200 [thread overview]
Message-ID: <200610101847.39604.netdev@axxeo.de> (raw)
In-Reply-To: <1160496263.3000.312.camel@laptopd505.fenrus.org>
Hi Arjan,
Arjan van de Ven wrote:
> Index: linux-2.6.19-rc1-git6/mm/slab.c
> ===================================================================
> --- linux-2.6.19-rc1-git6.orig/mm/slab.c
> +++ linux-2.6.19-rc1-git6/mm/slab.c
> @@ -926,7 +926,7 @@ static void __devinit start_cpu_timer(in
> if (keventd_up() && reap_work->func == NULL) {
> init_reap_node(cpu);
> INIT_WORK(reap_work, cache_reap, NULL);
> - schedule_delayed_work_on(cpu, reap_work, HZ + 3 * cpu);
> + schedule_delayed_work_on(cpu, reap_work, __round_jiffies_relative(HZ, cpu));
> }
> }
>
Did you changed the behavior by intention?
You seem to miss the factor "3" here. This hunk should read:
--- linux-2.6.19-rc1-git6.orig/mm/slab.c
+++ linux-2.6.19-rc1-git6/mm/slab.c
@@ -926,7 +926,7 @@ static void __devinit start_cpu_timer(in
if (keventd_up() && reap_work->func == NULL) {
init_reap_node(cpu);
INIT_WORK(reap_work, cache_reap, NULL);
- schedule_delayed_work_on(cpu, reap_work, HZ + 3 * cpu);
+ schedule_delayed_work_on(cpu, reap_work, __round_jiffies_relative(HZ, 3 * cpu));
}
}
In case you apply it:
Signed-off-by: Ingo Oese <netdev@axxeo.de>
Regards
Ingo Oeser
next prev parent reply other threads:[~2006-10-10 16:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-10 16:02 [patch 0/2] Introduce round_jiffies() to save spurious wakeups Arjan van de Ven
2006-10-10 16:03 ` [patch 1/2] round_jiffies infrastructure Arjan van de Ven
2006-10-10 16:04 ` [patch 2/2] round_jiffies users Arjan van de Ven
2006-10-10 16:47 ` Ingo Oeser [this message]
2006-10-10 16:59 ` Arjan van de Ven
2006-10-10 22:47 ` Paul Dickson
2006-10-10 23:52 ` Arjan van de Ven
2006-10-10 18:56 ` [patch 1/2] round_jiffies infrastructure Andrew Morton
2006-10-10 20:48 ` Arjan van de Ven
2006-10-16 13:42 ` Andi Kleen
2006-10-11 17:23 ` [patch 0/2] Introduce round_jiffies() to save spurious wakeups Christoph Hellwig
2006-10-11 17:54 ` Arjan van de Ven
2006-10-12 19:02 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610101847.39604.netdev@axxeo.de \
--to=netdev@axxeo.de \
--cc=akpm@osdl.org \
--cc=arjan@linux.intel.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.