All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: "Frédéric Riss" <frederic.riss@gmail.com>
Cc: Arjan van de Ven <arjan@infradead.org>,
	Linus Torvalds <torvalds@osdl.org>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	len.brown@intel.com
Subject: Re: 2.6.18 suspend regression on Intel Macs
Date: Tue, 10 Oct 2006 21:50:22 +0200	[thread overview]
Message-ID: <20061010195022.GA32134@elf.ucw.cz> (raw)
In-Reply-To: <1160509584.5134.11.camel@funkylaptop>

Hi!

> > > So what's the plan? Should/Will the ACPI guys remove the bit-preserving
> > > change brought in with the latest ACPICA merge?
> > 
> > 
> > it sounds like a good idea to at least put the workaround back for now,
> > until a more elegant solution (maybe something can be done to make it
> > not needed anymore) is found...
> > (or until it shows it breaks other machines at which point
> > reconsideration is also needed)
> 
> The workaround hasn't been removed. It's still there,
> drivers/acpi/pci_link.c:
> 788 
> 789 /* Make sure SCI is enabled again (Apple firmware bug?) */
> 790 acpi_set_register(ACPI_BITREG_SCI_ENABLE, 1, ACPI_MTX_DO_NOT_LOCK);
> 791 
> 
> The thing is acpi_set_register doesn't permit anymore to write the SCI
> bit since the last ACPI merge. Or maybe you meant that the
> acpi_hw_register_write modifications should be reverted until a better
> solution is found?

Maybe you can just create a patch that modifies ACPI not to mask the
SCI bit? Reverting big chunk of ACPI code is likely not the right
solution.

								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2006-10-10 19:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-09 18:19 2.6.18 suspend regression on Intel Macs Frédéric Riss
2006-10-10 10:39 ` Pavel Machek
2006-10-10 10:41   ` Arjan van de Ven
2006-10-10 10:49     ` Pavel Machek
2006-10-10 15:33     ` Linus Torvalds
2006-10-10 19:08       ` Frédéric Riss
2006-10-10 19:38         ` Arjan van de Ven
2006-10-10 19:46           ` Frédéric Riss
2006-10-10 19:50             ` Pavel Machek [this message]
2006-10-10 21:49               ` Linus Torvalds
2006-10-10 22:09                 ` Frédéric Riss
2006-10-10 23:53                   ` Linus Torvalds
2006-10-11  6:09                     ` Frédéric Riss
2006-10-11 13:16                     ` suspend debugging " Pavel Machek
2006-10-11  6:35                 ` Len Brown
2006-10-11 14:35                   ` Linus Torvalds
2006-10-10 21:28     ` Matthew Garrett
2006-10-11  6:37       ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061010195022.GA32134@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=arjan@infradead.org \
    --cc=frederic.riss@gmail.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.