All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Buesch <mb@bu3sch.de>
To: David Kimdon <david.kimdon@devicescape.com>
Cc: netdev@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>,
	Jiri Benc <jbenc@suse.cz>
Subject: Re: [patch 2/3] d80211: remove poorly documented ieee80211_hw extra_hdr_room flag
Date: Tue, 10 Oct 2006 23:04:05 +0200	[thread overview]
Message-ID: <200610102304.05291.mb@bu3sch.de> (raw)
In-Reply-To: <20061010134533.GB4518@devicescape.com>

On Tuesday 10 October 2006 15:45, David Kimdon wrote:
> On Tue, Oct 10, 2006 at 12:00:12PM +0200, Michael Buesch wrote:
> > On Monday 09 October 2006 19:03, David Kimdon wrote:
> > > This flag is unused by all in tree drivers.  Furthermore, the way that
> > > it is documented is not consistent with the way it is actually used by
> > > ieee80211.c.  The original attempt appears to be something to do with
> > > adding extra header room for low-level drivers which need to pad the
> > > IEEE 802.11 header (example: Atheros).
> > 
> > What about not removing it, but extending it.
> 
> Sure, I would be happy with that.  For Atheros it will be '2' to
> ensure that we can properly align the packet in the tx path without
> needing to realloc. 

Ok, nice. Do you want to do a patch or should I do?

-- 
Greetings Michael.

  parent reply	other threads:[~2006-10-10 21:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20061009170159.804032000@devicescape.com>
2006-10-09 17:02 ` [patch 1/3] d80211: use FCS_LEN instead of hardcoded number David Kimdon
2006-10-09 17:03 ` [patch 2/3] d80211: remove poorly documented ieee80211_hw extra_hdr_room flag David Kimdon
2006-10-10 10:00   ` Michael Buesch
2006-10-10 13:45     ` David Kimdon
2006-10-10 14:30       ` Michael Wu
2006-10-10 21:04       ` Michael Buesch [this message]
2006-10-11  0:37         ` David Kimdon
2006-10-09 17:03 ` [patch 3/3] d80211: silence sparse warning: bad constant expression David Kimdon
2006-10-09 20:11   ` David Kimdon
2006-10-18 13:56     ` Jiri Benc
2006-10-18 15:12       ` David Kimdon
2006-10-18 15:40         ` Jiri Benc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200610102304.05291.mb@bu3sch.de \
    --to=mb@bu3sch.de \
    --cc=david.kimdon@devicescape.com \
    --cc=jbenc@suse.cz \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.