From: Amit Choudhary <amit2030@gmail.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH 2.6.19-rc1 1/2] drivers/media/video/se401.c: check kmalloc() return value.
Date: Tue, 10 Oct 2006 23:36:23 -0700 [thread overview]
Message-ID: <20061010233623.95a47224.amit2030@gmail.com> (raw)
Description: Check the return value of kmalloc() in function se401_start_stream(), in file drivers/media/video/se401.c.
Signed-off-by: Amit Choudhary <amit2030@gmail.com>
diff --git a/drivers/media/video/se401.c b/drivers/media/video/se401.c
index 7aeec57..20b91db 100644
--- a/drivers/media/video/se401.c
+++ b/drivers/media/video/se401.c
@@ -57,6 +57,7 @@ MODULE_PARM_DESC(flickerless, "Net frequ
module_param(video_nr, int, 0);
static struct usb_driver se401_driver;
+static int se401_stop_stream(struct usb_se401 *se401);
/**********************************************************************
@@ -450,6 +451,11 @@ static int se401_start_stream(struct usb
}
for (i=0; i<SE401_NUMSBUF; i++) {
se401->sbuf[i].data=kmalloc(SE401_PACKETSIZE, GFP_KERNEL);
+ /* No memory, stop streaming */
+ if (!se401->sbuf[i].data) {
+ se401_stop_stream(se401);
+ return -ENOMEM;
+ }
}
se401->bayeroffset=0;
@@ -458,6 +464,11 @@ static int se401_start_stream(struct usb
se401->scratch_overflow=0;
for (i=0; i<SE401_NUMSCRATCH; i++) {
se401->scratch[i].data=kmalloc(SE401_PACKETSIZE, GFP_KERNEL);
+ /* No memory, stop streaming */
+ if (!se401->scratch[i].data) {
+ se401_stop_stream(se401);
+ return -ENOMEM;
+ }
se401->scratch[i].state=BUFFER_UNUSED;
}
reply other threads:[~2006-10-11 6:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061010233623.95a47224.amit2030@gmail.com \
--to=amit2030@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.