From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Jeff Garzik <jeff@garzik.org>
Cc: linux-scsi@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] SCSI: minor bug fixes and cleanups
Date: Wed, 11 Oct 2006 08:18:24 +0200 [thread overview]
Message-ID: <200610110818.25158.eike-kernel@sf-tec.de> (raw)
In-Reply-To: <20061010232231.GA19015@havoc.gtf.org>
[-- Attachment #1: Type: text/plain, Size: 1327 bytes --]
Jeff Garzik wrote:
> BusLogic: use kzalloc(), remove cast to/from void*
>
> aic7xxx_old: fix typo in cast
>
> NCR53c406a: ifdef out static built code
>
> fd_mcs: ifdef out static built code
>
> ncr53c8xx: ifdef out static built code
>
> Signed-off-by: Jeff Garzik <jeff@garzik.org>
>
> ---
>
> drivers/scsi/BusLogic.c | 12 ++++++------
> drivers/scsi/NCR53c406a.c | 5 +++++
> drivers/scsi/aic7xxx_old.c | 2 +-
> drivers/scsi/fd_mcs.c | 2 ++
> drivers/scsi/ncr53c8xx.c | 19 +++++++++++--------
>
> diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c
> index 7c59bba..689dc4c 100644
> --- a/drivers/scsi/BusLogic.c
> +++ b/drivers/scsi/BusLogic.c
> @@ -2186,21 +2186,21 @@ #endif
>
> if (BusLogic_ProbeOptions.NoProbe)
> return -ENODEV;
> - BusLogic_ProbeInfoList = (struct BusLogic_ProbeInfo *)
> - kmalloc(BusLogic_MaxHostAdapters * sizeof(struct BusLogic_ProbeInfo),
> GFP_ATOMIC); + BusLogic_ProbeInfoList =
> + kzalloc(BusLogic_MaxHostAdapters * sizeof(struct BusLogic_ProbeInfo),
> GFP_KERNEL); if (BusLogic_ProbeInfoList == NULL) {
> BusLogic_Error("BusLogic: Unable to allocate Probe Info List\n", NULL);
> return -ENOMEM;
> }
> - memset(BusLogic_ProbeInfoList, 0, BusLogic_MaxHostAdapters *
> sizeof(struct BusLogic_ProbeInfo));
kcalloc
Eike
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2006-10-11 6:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-10 23:22 [PATCH] SCSI: minor bug fixes and cleanups Jeff Garzik
2006-10-11 6:18 ` Rolf Eike Beer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610110818.25158.eike-kernel@sf-tec.de \
--to=eike-kernel@sf-tec.de \
--cc=akpm@osdl.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.