From: Jens Axboe <jens.axboe@oracle.com>
To: Vasily Tarasov <vtaras@openvz.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
OpenVZ Developer List <devel@openvz.org>
Subject: Re: [PATCH] block layer: elv_iosched_show should get elv_list_lock
Date: Wed, 11 Oct 2006 13:23:14 +0200 [thread overview]
Message-ID: <20061011112314.GP6515@kernel.dk> (raw)
In-Reply-To: <200610111119.k9BBJhls004763@vass.7ka.mipt.ru>
On Wed, Oct 11 2006, Vasily Tarasov wrote:
> elv_iosched_show function iterates other elv_list,
> hence elv_list_lock should be got.
Indeed, that's a bug. Thanks!
> Also the question is: in elv_iosched_show, elv_iosched_store
> q->elevator->elevator_type construction is used without locking
> q->queue_lock. Is it expected?..
As long as the queue doesn't go away, we should be safe enough.
--
Jens Axboe
prev parent reply other threads:[~2006-10-11 11:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-11 11:19 [PATCH] block layer: elv_iosched_show should get elv_list_lock Vasily Tarasov
2006-10-11 11:23 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061011112314.GP6515@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vtaras@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.