Re: [PATCH] Add carta_random32() library routine

[Andrew Morton <akpm@osdl.org>]

On Wed, 11 Oct 2006 15:22:57 -0400
Jeff Garzik <jeff@garzik.org> wrote:

> Linux Kernel Mailing List wrote:
> > commit e0ab2928cc2202f13f0574d4c6f567f166d307eb
> > tree 3df0b8e340b1a98cd8a2daa19672ff008e8fb7f9
> > parent b611967de4dc5c52049676c4369dcac622a7cdfe
> > author Stephane Eranian <eranian@hpl.hp.com> 1160554905 -0700
> > committer Linus Torvalds <torvalds@g5.osdl.org> 1160590461 -0700
> > 
> > [PATCH] Add carta_random32() library routine
> > 
> > This is a follow-up patch based on the review for perfmon2.  This patch
> > adds the carta_random32() library routine + carta_random32.h header file.
> > 
> > This is fast, simple, and efficient pseudo number generator algorithm.  We
> > use it in perfmon2 to randomize the sampling periods.  In this context, we
> > do not need any fancy randomizer.
> 
> hrm, does this really warrant inclusion into every kernel build, on 
> every platform?
> 

probly not really.  But putting it into lib.a has problems, and making it a
loadable module has problems, and making it Kconfigurable has problems. 
And it's only 150-odd bytes.

It'd be better to just start to use it.  There are a number of callers of
get_random_bytes() who just don't need such fanciness (and degradation or
/dev/urandom), such as ext2/3/4's Orlov allocator.