From: Andrew Morton <akpm@osdl.org>
To: David Brownell <david-b@pacbell.net>
Cc: Jeff Garzik <jeff@garzik.org>,
dbrownell@users.sourceforge.net,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] SPI: improve sysfs compiler complaint handling
Date: Thu, 12 Oct 2006 11:24:49 -0700 [thread overview]
Message-ID: <20061012112449.e9bb7e12.akpm@osdl.org> (raw)
In-Reply-To: <200610121108.59727.david-b@pacbell.net>
On Thu, 12 Oct 2006 11:08:59 -0700
David Brownell <david-b@pacbell.net> wrote:
> On Wednesday 11 October 2006 6:49 pm, Jeff Garzik wrote:
>
> > The compiler complains, even with the "(void)".
>
> > - (void) device_for_each_child(master->cdev.dev, NULL, __unregister);
>
> Sure seems like a compiler bug to me.
Seems like a kernel bug to me. Look at device_del() and weep. It calls
eighty eight things which can fail, some of which randomly return void but
shouldn't, then drops the overall result on the floor.
So if something failed and you come up and reinsert the device or driver
two days later the kernel collapses in a heap and you don't have a clue
why.
You're just a victim of all this.
Who wrote all this stuff, and what were they thinking?
next prev parent reply other threads:[~2006-10-12 18:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-12 1:49 [PATCH] SPI: improve sysfs compiler complaint handling Jeff Garzik
2006-10-12 18:08 ` David Brownell
2006-10-12 18:24 ` Andrew Morton [this message]
2006-10-12 18:46 ` David Brownell
2006-10-12 19:08 ` Arjan van de Ven
2006-10-12 18:39 ` Arjan van de Ven
2006-10-12 19:07 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061012112449.e9bb7e12.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=david-b@pacbell.net \
--cc=dbrownell@users.sourceforge.net \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.