From: Stephen Hemminger <shemminger@osdl.org>
To: "Yang, Steve" <steve.yang@windriver.com>
Cc: <netdev@vger.kernel.org>
Subject: Re: [patch] Performance enhancement patches for SB1250 MAC
Date: Thu, 12 Oct 2006 15:13:56 -0700 [thread overview]
Message-ID: <20061012151356.4a3a4096@freekitty> (raw)
In-Reply-To: <D9055C0A0A86BD4E89AD96A89EA767DBA6AEBE@ALA-MAIL03.corp.ad.wrs.com>
On Thu, 12 Oct 2006 14:54:33 -0700
"Yang, Steve" <steve.yang@windriver.com> wrote:
> FYI ...
>
> Regards,
> Steve Yang
>
> -----Original Message-----
> From: Yang, Steve
> Sent: Monday, September 25, 2006 3:50 PM
> To: 'linux-mips@linux-mips.org'
> Cc: 'ralf@linux-mips.org'; 'Mark E Mason'
> Subject: Performance enhancement patches for SB1250 MAC
>
> Hi,
>
> The attached are two network performance enhancement patches for SB1250
> MAC. The NAPI patch applies first. Followed by the "skb cache" patch.
> They applied and builds cleanly on 2.6.18 kernel for the following
> kernel option combinations:
>
> SBMAC_NAPI no yes yes
> SKB_CACHE no no yes
>
> Regards,
> Steve Yang
>
NAK on the SKB_CACHE it is idea that just ends up favoring your
driver at the expense of the rest of the system. Also, there are
resource/memory starvation issues and probably other races as well.
I bet it makes your benchmark run faster, but it doesn't belong in
normal kernel
--
Stephen Hemminger <shemminger@osdl.org>
next prev parent reply other threads:[~2006-10-12 22:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-12 21:54 [patch] Performance enhancement patches for SB1250 MAC Yang, Steve
2006-10-12 22:13 ` Stephen Hemminger [this message]
[not found] <D9055C0A0A86BD4E89AD96A89EA767DBA6AFBC@ALA-MAIL03.corp.ad.wrs.com>
2006-10-13 20:24 ` Stephen Hemminger
-- strict thread matches above, loose matches on Subject: below --
2006-11-20 21:40 Yang, Steve
2006-11-20 23:35 ` Stephen Hemminger
2006-11-20 23:58 ` David Miller
2006-11-21 14:26 ` Martin Michlmayr
2006-11-21 16:45 Yang, Steve
2006-11-21 19:12 ` Stephen Hemminger
2006-11-22 0:33 Yang, Steve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061012151356.4a3a4096@freekitty \
--to=shemminger@osdl.org \
--cc=netdev@vger.kernel.org \
--cc=steve.yang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.