All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH,RFC] Add __GFP_ZERO to GFP_LEVEL_MASK
Date: Fri, 13 Oct 2006 13:46:35 -0700	[thread overview]
Message-ID: <20061013134635.a983e4d7.akpm@osdl.org> (raw)
In-Reply-To: <28729.1160771116@lwn.net>

On Fri, 13 Oct 2006 14:25:16 -0600
Jonathan Corbet <corbet@lwn.net> wrote:

> There is a very helpful comment in <linux/gfp.h>:
> 
>   /* if you forget to add the bitmask here kernel will crash, period */
> 
> Well, my kernel has been crashing (period) at the BUG() in cache_grow();
> the offending flag is __GFP_ZERO.  I think it needs to be in
> GFP_LEVEL_MASK.  Anybody know a good reason why it's not there now?
> 

It would be a bit odd to pass __GFP_ZERO into the slab allocator.  Slab
doesn't need that hint: it has its own ways of initialising the memory.

What is the callsite?

Thanks.


  reply	other threads:[~2006-10-13 20:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-13 20:25 [PATCH,RFC] Add __GFP_ZERO to GFP_LEVEL_MASK Jonathan Corbet
2006-10-13 20:46 ` Andrew Morton [this message]
2006-10-13 21:00   ` Jonathan Corbet
2006-10-13 21:31     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061013134635.a983e4d7.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=corbet@lwn.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.