From: Greg KH <greg@kroah.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH 2.6.19-rc2] drivers/usb/serial/mos7840.c: check
Date: Mon, 16 Oct 2006 16:46:56 +0000 [thread overview]
Message-ID: <20061016164656.GA11331@kroah.com> (raw)
In-Reply-To: <20061015225513.f35312ec.amit2030@gmail.com>
On Sun, Oct 15, 2006 at 10:55:13PM -0700, Amit Choudhary wrote:
> Description: Check the return value of kmalloc() in function mos7840_get_reg(), in file drivers/usb/serial/mos7840.c.
>
> Signed-off-by: Amit Choudhary <amit2030@gmail.com>
>
> diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
> index 021be39..91d474b 100644
> --- a/drivers/usb/serial/mos7840.c
> +++ b/drivers/usb/serial/mos7840.c
> @@ -475,6 +475,14 @@ static int mos7840_get_reg(struct moschi
> int ret = 0;
> buffer = (__u8 *) mcs->ctrl_buf;
>
> + /* The memory for ctrl_buf is allocated in
> + * mos7840_startup(), but it is not checked if
> + * kmalloc failed. So, mcs->ctrl_buf might be NULL.
> + * So, it should be checked here.
> + */
> + if (!buffer)
> + return -ENOMEM;
Why not just check it in the startup function instead?
thanks,
greg k-h
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2006-10-16 16:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-16 5:55 [KJ] [PATCH 2.6.19-rc2] drivers/usb/serial/mos7840.c: check Amit Choudhary
2006-10-16 16:46 ` Greg KH [this message]
2006-10-17 6:33 ` Amit Choudhary
2006-10-18 21:23 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061016164656.GA11331@kroah.com \
--to=greg@kroah.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.