From: Dave Jones <davej@redhat.com>
To: miura@da-cha.org
Cc: cpufreq@lists.linux.org.uk
Subject: speedstep-smi detection broken.
Date: Tue, 17 Oct 2006 01:55:29 -0400 [thread overview]
Message-ID: <20061017055529.GJ32681@redhat.com> (raw)
If someone inserts speedstep-smi on a mobile P4,
it prevents other cpufreq modules from loading until it
is unloaded.
Opinions on this patch ?
(I'm tempted to just remove the printk too).
Dave
--- local-git/arch/i386/kernel/cpu/cpufreq/speedstep-smi.c~ 2006-10-17 01:53:29.000000000 -0400
+++ local-git/arch/i386/kernel/cpu/cpufreq/speedstep-smi.c 2006-10-17 01:54:02.000000000 -0400
@@ -362,7 +362,7 @@ static int __init speedstep_init(void)
break;
case SPEEDSTEP_PROCESSOR_P4M:
printk(KERN_INFO "speedstep-smi: you're trying to use this cpufreq driver on a Pentium 4-based CPU. Most likely it will not work.\n");
- break;
+ return -ENODEV;
default:
speedstep_processor = 0;
}
--
http://www.codemonkey.org.uk
next reply other threads:[~2006-10-17 5:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-17 5:55 Dave Jones [this message]
2006-10-17 14:00 ` speedstep-smi detection broken Hiroshi Miura
2006-10-17 18:07 ` Dave Jones
2006-10-18 3:59 ` Hiroshi Miura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061017055529.GJ32681@redhat.com \
--to=davej@redhat.com \
--cc=cpufreq@lists.linux.org.uk \
--cc=miura@da-cha.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.