From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Jones Subject: Re: speedstep-smi detection broken. Date: Tue, 17 Oct 2006 14:07:45 -0400 Message-ID: <20061017180745.GD18353@redhat.com> References: <20061017055529.GJ32681@redhat.com> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: cpufreq-bounces@lists.linux.org.uk Errors-To: cpufreq-bounces+glkc-cpufreq=m.gmane.org+glkc-cpufreq=m.gmane.org@lists.linux.org.uk Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Hiroshi Miura Cc: cpufreq@lists.linux.org.uk On Tue, Oct 17, 2006 at 11:00:42PM +0900, Hiroshi Miura wrote: > I prefer removing all of P4M case block if you remove the printk too. > This means simply not to support P4M with this driver and > return -ENODEV. > If user turn on debug flag, they may see > dprintk ("No supported Intel CPU detected.\n"); > as same as other CPUs. Yes, even better. I'll apply this. Want me to fake a Signed-off-by: from you, as you forgot to add one? :) Dave -- http://www.codemonkey.org.uk