From: Al Viro <viro@ftp.linux.org.uk>
To: Andrew Morton <akpm@osdl.org>
Cc: Josef Sipek <jsipek@fsl.cs.sunysb.edu>,
linux-kernel@vger.kernel.org, hch@infradead.org,
mhalcrow@us.ibm.com, penberg@cs.helsinki.fi,
linux-fsdevel@vger.kernel.org
Subject: Re: fsstack: struct path
Date: Wed, 18 Oct 2006 10:06:23 +0100 [thread overview]
Message-ID: <20061018090623.GK29920@ftp.linux.org.uk> (raw)
In-Reply-To: <20061018013551.3745e1d5.akpm@osdl.org>
On Wed, Oct 18, 2006 at 01:35:51AM -0700, Andrew Morton wrote:
> On Wed, 18 Oct 2006 01:31:03 -0700
> Andrew Morton <akpm@osdl.org> wrote:
>
> > > One, rather unfortunate, fact is that struct path is also defined in
> > > include/linux/reiserfs_fs.h as something completely different - reiserfs
> > > specific.
> > >
> > > Any thoughts?
> > >
> >
> > reiserfs is being bad. s/path/reiserfs_path/g
>
> There's also drivers/md/dm-mpath.h's struct path. Renaming fs/namei.c's
> `struct path' to `struct namei_path' would be prudent.
Yuck... If we really want to switch to it (and I can give you a dozen
examples of possible users right now - starting with struct file), putting
namei_ into it is both uninformative and ugly.
I'm not sure what would be the good name here; "pathname" comes to mind,
but it suggests that we are dealing with a string. And "location" is
too vague (and probably would cause fsckloads of conflicts itself).
Suggestions? "pathname" would almost work; the difference is that this
is not a string but a node in tree that string resolves to.
next prev parent reply other threads:[~2006-10-18 9:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-18 4:23 fsstack: struct path Josef Sipek
2006-10-18 8:31 ` Andrew Morton
2006-10-18 8:35 ` Al Viro
2006-10-18 14:38 ` Chris Mason
2006-10-18 8:35 ` Andrew Morton
2006-10-18 9:06 ` Al Viro [this message]
2006-10-18 9:12 ` Andrew Morton
2006-10-18 9:22 ` Al Viro
2006-10-18 9:27 ` Paul Jackson
2006-10-18 9:34 ` Al Viro
2006-10-18 10:56 ` Jörn Engel
2006-10-18 10:56 ` Jörn Engel
2006-10-18 14:39 ` Erez Zadok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061018090623.GK29920@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=jsipek@fsl.cs.sunysb.edu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhalcrow@us.ibm.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.