From: Andi Kleen <ak@muc.de>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
jbeulich@novell.com
Subject: Re: [PATCH 2.6.19-rc2-mm1] Fix fake return address
Date: 18 Oct 2006 13:15:46 +0200
Date: Wed, 18 Oct 2006 13:15:46 +0200 [thread overview]
Message-ID: <20061018111546.GA53305@muc.de> (raw)
In-Reply-To: <45358FB2.5000606@goop.org>
On Tue, Oct 17, 2006 at 07:21:38PM -0700, Jeremy Fitzhardinge wrote:
> The fake return address was being set to __KERNEL_PDA, rather than 0.
> Push it earlier while %eax still equals 0.
Oops. That might explain some of the unwind problems. Thanks.
-Andi
>
> Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com>
> Cc: Andi Kleen <ak@muc.de>
> Cc: Andrew Morton <akpm@osdl.org>
>
> diff -r b8e58159855c arch/i386/kernel/head.S
> --- a/arch/i386/kernel/head.S Tue Oct 17 19:04:59 2006 -0700
> +++ b/arch/i386/kernel/head.S Tue Oct 17 19:05:46 2006 -0700
> @@ -316,12 +316,12 @@ 1: movl $(__KERNEL_DS),%eax # reload all
> xorl %eax,%eax # Clear FS and LDT
> movl %eax,%fs
> lldt %ax
> + pushl %eax # fake return address
>
> movl $(__KERNEL_PDA),%eax
> mov %eax,%gs
>
> cld # gcc2 wants the direction flag cleared at
> all times
> - pushl %eax # fake return address
> #ifdef CONFIG_SMP
> movb ready, %cl
> movb $1, ready
>
>
>
prev parent reply other threads:[~2006-10-18 11:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-18 2:21 [PATCH 2.6.19-rc2-mm1] Fix fake return address Jeremy Fitzhardinge
2006-10-18 11:15 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061018111546.GA53305@muc.de \
--to=ak@muc.de \
--cc=akpm@osdl.org \
--cc=jbeulich@novell.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.