Re: [PATCH] Request OMAP MMC Write-protect pin

[Tony Lindgren <tony@atomide.com>]

Hi,

* andrzej zaborowski <balrog@zabor.org> [060922 23:17]:
> [Sorry, forgot about the actual diff]
> 
> Adds code that requests and frees the WP GPIO pin in OMAP MMC host
> driver, similarly to how the MMC Power and MMC Cover-switch GPIOs are
> treated.
> 
> Signed-off-by: Andrzej Zaborowski <balrog@zabor.org>
> 
> diff --git a/drivers/mmc/omap.c b/drivers/mmc/omap.c
> index ae08a37..a01682b 100644
> --- a/drivers/mmc/omap.c
> +++ b/drivers/mmc/omap.c
> @@ -1009,7 +1009,7 @@ static int mmc_omap_get_ro(struct mmc_ho
>  {
>  	struct mmc_omap_host *host = mmc_priv(mmc);
>  
> -	return host->wp_pin && omap_get_gpio_datain(host->wp_pin);
> +	return (host->wp_pin >= 0) && omap_get_gpio_datain(host->wp_pin);
>  }

...

This all looks OK, but let's wait on this as I believe there are
some patches coming to deal with it in board-*.c files.

Regards,

Tony