From: Andi Kleen <ak@suse.de>
To: Daniel Drake <ddrake@brontes3d.com>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: Unnecessary BKL contention in video1394
Date: Thu, 19 Oct 2006 15:27:42 +0200 [thread overview]
Message-ID: <200610191527.42802.ak@suse.de> (raw)
In-Reply-To: <1161263978.2845.6.camel@systems03.lan.brontes3d.com>
> Adding Andi Kleen to CC, who added the BKL around __video1394_ioctl a
> long while back (when converting video1394 to compat_ioctl).
>
> I don't feel that any replacement protection is needed, since the
> critical sections (where structures are used both in interrupts and in
> file_operations) are already protected by spinlocks.
Fine by me. I just did it to preserve old semantics because I didn't want
to audit the 1394 locking. But if you think it's not needed feel free to remove
them.
-andi
next prev parent reply other threads:[~2006-10-19 13:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1161203487.28713.8.camel@systems03.lan.brontes3d.com>
2006-10-18 21:36 ` Unnecessary BKL contention in video1394 Stefan Richter
2006-10-19 13:19 ` Daniel Drake
2006-10-19 13:27 ` Andi Kleen [this message]
2006-10-19 14:36 ` Stefan Richter
2006-10-19 15:31 ` Daniel Drake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610191527.42802.ak@suse.de \
--to=ak@suse.de \
--cc=ddrake@brontes3d.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.