From: Olof Johansson <olof@lixom.net>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 5/5] powerpc: Cell timebase bug workaround
Date: Thu, 19 Oct 2006 20:56:20 -0500 [thread overview]
Message-ID: <20061019205620.2658cbfd@pb15> (raw)
In-Reply-To: <1161308840.10524.112.camel@localhost.localdomain>
On Fri, 20 Oct 2006 11:47:20 +1000 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> static inline unsigned int get_tbu(void)
> {
> +#ifdef CONFIG_403GCX
> unsigned int tbu;
> -
> -#if defined(CONFIG_403GCX)
> asm volatile("mfspr %0, 0x3dc" : "=r" (tbu));
> + return tbu;
> +#elif defined(CONFIG_PPC32)
> + return mftbu();
> #else
> - asm volatile("mftbu %0" : "=r" (tbu));
> + return mftb();
> #endif
> - return tbu;
> }
>
Shouldn't the last one be mftbu(), since that's what the asm used to do?
-Olof
next prev parent reply other threads:[~2006-10-20 1:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-20 1:47 [PATCH 5/5] powerpc: Cell timebase bug workaround Benjamin Herrenschmidt
2006-10-20 1:56 ` Olof Johansson [this message]
2006-10-20 4:37 ` [PATCH 5/5] powerpc: Cell timebase bug workaround #3 Benjamin Herrenschmidt
2006-10-20 5:24 ` Olof Johansson
2006-10-20 5:37 ` Benjamin Herrenschmidt
2006-10-20 6:02 ` Olof Johansson
-- strict thread matches above, loose matches on Subject: below --
2006-10-13 8:04 [PATCH 5/5] powerpc: Cell timebase bug workaround Benjamin Herrenschmidt
2006-10-14 2:14 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061019205620.2658cbfd@pb15 \
--to=olof@lixom.net \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.