From: David Miller <davem@davemloft.net>
To: sparclinux@vger.kernel.org
Subject: Re: Unaligned accesses in compat_sys_msgrcv and sys_msgrcv
Date: Sat, 21 Oct 2006 06:35:58 +0000 [thread overview]
Message-ID: <20061020.233558.10299339.davem@davemloft.net> (raw)
In-Reply-To: <20061021041107.GA4629@droopy.oc.cox.net>
From: Jurij Smakov <jurij@wooyd.org>
Date: Fri, 20 Oct 2006 21:11:08 -0700
> p = compat_alloc_user_space(second + sizeof(struct msgbuf));
>
> at ipc/compat.c:352 does not guarantee alignment of p, so when we
> later try to ldxa from the address &p->mtype (in get_user) or stxa
> to &msgp->mtype (in put_user), we catch an exception.
>
> As I'm not sure what would be the correct fix here, I'd appreciate any
> advice on how to deal with that.
compat_alloc_user_space() should round down the pointer it returns
to be 8-byte aligned.
Thanks for catching this, I'll cook up a patch over the weekend.
What application is calling sys_msgrev() during a compile btw?
next prev parent reply other threads:[~2006-10-21 6:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-21 4:11 Unaligned accesses in compat_sys_msgrcv and sys_msgrcv Jurij Smakov
2006-10-21 6:35 ` David Miller [this message]
2006-10-23 4:54 ` David Miller
2006-10-23 16:52 ` Jurij Smakov
2006-10-23 21:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061020.233558.10299339.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.