From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Veillard <veillard@redhat.com>
Subject: Re: [PATCH] don't use mlock() with Solaris tools
Date: Fri, 20 Oct 2006 18:35:28 -0400
Message-ID: <20061020223527.GC28613@redhat.com>
References: <20061020034247.GB4480@totally.trollied.org>
Reply-To: veillard@redhat.com
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <20061020034247.GB4480@totally.trollied.org>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: John Levon <levon@movementarian.org>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On Fri, Oct 20, 2006 at 04:42:47AM +0100, John Levon wrote:
> on solaris: mlock requires a page aligned address and mlock doesn't ensure the pages won't minor page fault; so don't use it on solaris.
[...]
> -/* NB: arr must be mlock'ed */
> +int lock_pages(void *addr, size_t len)
> +{
> +      int e = 0;
> +#ifndef __sun__
> +      e = mlock(addr, len);
> +#endif
> +      return (e);
> +}
> +
> +void unlock_pages(void *addr, size_t len)
> +{
> +#ifndef __sun__
> +	safe_munlock(addr, len);
> +#endif
> +}
> +

  So on Solaris you don't pin down the memory used for hypercall parameters
and results at all ? Is there really no risk associated with this strategy ?

  surprised,

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard@redhat.com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/