From: Steven Smith <sos22-xen@srcf.ucam.org>
To: "Dong, Eddie" <eddie.dong@intel.com>
Cc: xen-devel@lists.xensource.com, sos22@srcf.ucam.org, ssmith@xensource.com
Subject: Re: removing event notification for HVM IRQ injection?
Date: Sun, 22 Oct 2006 10:10:00 +0100 [thread overview]
Message-ID: <20061022091000.GA1814@cam.ac.uk> (raw)
In-Reply-To: <0E6FE5D295DE5B4B8D9070C26A2279873EEC87@pdsmsx411.ccr.corp.intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 1107 bytes --]
> When looking at improving the HVM TPR acceleration, I noticed
> your previous patch (CSET:10974) replaced evtchn_set_pending in both
> hlt_timer_fn & vlapic_accept_irq with hvm_prod_vcpu. I am not sure for
> the purpose
The aim here was to make sure that HVM domains could use Xen event
channels normally without interfering with the device model's use of
them. Previously, the device model fired an event channel into the
HVM domain to tell it to wake up, and this could cause problems (or at
least confusion) if the domain was trying to use event channels for
its own purposes. After this patch, the device model event channel
terminates in Xen, which is much easier to work with.
> but at least one thing is missed after this patch: previous
> evtchn_set_pending may use physical IPI to interrupt target VP while
> hvm_prod_vcpu not. If the target VP is running, delivering guest IRQ (
> both hlt_timer_fn & vlapic_accept_irq ) to a running VP have to use
> physical IPI to interrupt the execution to inject IRQ, without this the
> logic may be wrong.
I think Keir already answered this.
Steven.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2006-10-22 9:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-20 9:10 removing event notification for HVM IRQ injection? Dong, Eddie
2006-10-20 18:09 ` Keir Fraser
2006-10-22 9:10 ` Steven Smith [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-10-22 9:04 Dong, Eddie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061022091000.GA1814@cam.ac.uk \
--to=sos22-xen@srcf.ucam.org \
--cc=eddie.dong@intel.com \
--cc=sos22@srcf.ucam.org \
--cc=ssmith@xensource.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.