From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:38054 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S1750990AbWJWAnQ (ORCPT ); Sun, 22 Oct 2006 20:43:16 -0400 From: Andi Kleen Subject: Re: dealing with excessive includes Date: Mon, 23 Oct 2006 02:42:58 +0200 References: <20061018091944.GA5343@martell.zuzino.mipt.ru> <20061023003111.GD25210@parisc-linux.org> In-Reply-To: <20061023003111.GD25210@parisc-linux.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200610230242.58647.ak@suse.de> Sender: linux-arch-owner@vger.kernel.org To: Matthew Wilcox Cc: Geert Uytterhoeven , Randy Dunlap , Stefan Richter , Al Viro , Linus Torvalds , Alexey Dobriyan , Linux Kernel Development , linux-arch@vger.kernel.org List-ID: > /*+ > * Provides: struct sched > * Provides: total_forks, nr_threads, process_counts, nr_processes() > * Provides: nr_running(), nr_uninterruptible(), nr_active(), nr_iowait(), weighted_cpuload() > */ That's ugly. If it needs that i don't think it's a good idea. We really want standard C, not some Linux dialect. In theory it is even to do it automated without comments just based on the referenced symbols, except if stuff is hidden in macros (but then the include defining the macro should have the right includes anyways). Another issue would be different name spaces - if there is both typedef foo and struct foo and nested local foo a script might have a little trouble distingushing them, but i suspect that won't be a big issue. -Andi