From: Christoph Hellwig <hch@infradead.org>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Andrew Morton <akpm@osdl.org>, Jeff Garzik <jgarzik@pobox.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH 2.6.18] defxx: Big-endian hosts support
Date: Mon, 23 Oct 2006 15:48:44 +0100 [thread overview]
Message-ID: <20061023144844.GA30864@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.64N.0610231330190.4426@blysk.ds.pg.gda.pl>
On Mon, Oct 23, 2006 at 01:53:17PM +0100, Maciej W. Rozycki wrote:
> + data = cpu_to_le32(data);
This is rather ugly and not provable by static typechecking. Please
always use spearate variables/structs for device and host endian values,
and run the resulting driver through sparse to make sure everything is
correct.
next prev parent reply other threads:[~2006-10-23 14:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-23 12:53 [PATCH 2.6.18] defxx: Big-endian hosts support Maciej W. Rozycki
2006-10-23 14:48 ` Christoph Hellwig [this message]
2006-10-24 11:57 ` Maciej W. Rozycki
2006-11-06 8:13 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061023144844.GA30864@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=macro@linux-mips.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.