From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber de Oliveira Costa Subject: [PATCH][RESEND] Better error reporting in config file parsing errors Date: Mon, 23 Oct 2006 16:35:15 -0300 Message-ID: <20061023193515.GC14072@redhat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="jousvV0MzM2p6OtC" Return-path: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org --jousvV0MzM2p6OtC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hello, I lost some time today using xm create, while invoking 'xm create cfg', because I accidentally had a file called 'cfg' in my current working directory. As the error dumping refers only to 'cfg', it revealed itself somehow tricky to figure out. I'm attaching a patch that informs the complete path of the file being processing, besides giving a more complete error message that would give more valuable input to help finding any issues. Comments very welcome. -- Glauber de Oliveira Costa Red Hat Inc. "Free as in Freedom" --jousvV0MzM2p6OtC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename="synerr.patch" --- xen-3.0.3-testing-11633/tools/python/xen/xm/opts.py.orig 2006-09-28 18:52:39.000000000 -0400 +++ xen-3.0.3-testing-11633/tools/python/xen/xm/opts.py 2006-10-20 16:59:35.000000000 -0400 @@ -483,11 +483,8 @@ class Opts: 'path' search path 'defconfig' script name """ - for x in [ '' ] + self.vals.path.split(':'): - if x: - p = os.path.join(x, self.vals.defconfig) - else: - p = self.vals.defconfig + for x in [ os.path.curdir ] + self.vals.path.split(':'): + p = os.path.join(x, self.vals.defconfig) if os.path.exists(p): self.info('Using config file "%s".' % p) self.load(p, help) @@ -518,6 +515,10 @@ class Opts: exec cmd in globs, locs try: execfile(defconfig, globs, locs) + except SyntaxError,e: + raise SyntaxError, \ + "Errors were found at line %d while processing %s:\n\t%s"\ + %(e.lineno,defconfig,e.text) except: if not help: raise if help: --jousvV0MzM2p6OtC Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --jousvV0MzM2p6OtC--