From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan Harper Subject: Re: [PATCH 6/6] xen,tools: add numa stat tool and hcalls Date: Mon, 23 Oct 2006 16:11:23 -0500 Message-ID: <20061023211123.GM25762@us.ibm.com> References: <20061023180928.GK25762@us.ibm.com> <20061023204926.GC28984@totally.trollied.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20061023204926.GC28984@totally.trollied.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: John Levon Cc: Ryan Harper , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org * John Levon [2006-10-23 15:53]: > On Mon, Oct 23, 2006 at 01:09:28PM -0500, Ryan Harper wrote: > > > This patch adds a tool used to display how memory for each domain was > > allocated (which nodes does a domain's memory reside within). It also > > dumps information about the Xen heap, including how many pages are in > > each zone and node. > > + struct xen_domctl_availheap availheap; > + struct xen_domctl_getdomnodestat getdomnodestat; > uint8_t pad[128]; > > Don't you need to alter the pad to compensate? AFAIK, I don't. My understanding is that the pad[128] is the maximum size for any member of the union. Neither of the two added hypercalls exceed 128. -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx (512) 838-9253 T/L: 678-9253 ryanh@us.ibm.com