All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Thomas Maier <balagi@justmail.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.6.19-rc2-mm2 sysfs: sysfs_write_file() writes zero terminated data
Date: Mon, 23 Oct 2006 14:18:35 -0700	[thread overview]
Message-ID: <20061023211835.GA27613@suse.de> (raw)
In-Reply-To: <op.thv4lpt0iudtyh@master>

On Mon, Oct 23, 2006 at 10:02:03PM +0200, Thomas Maier wrote:
> Hello,
> 
> Sorry, maybe i missed something, but according to the
> code in fs/sysfs/file.c the "write" sequence is:
> 
> - call to sysfs_write_file(ubuf, count)
> - if (!sysfsbuf->page)  alloc zeroed page
> - copy count bytes from ubuf to sysfsbuf->page
> - call store(sysfsbuf->page, count)
> 
> When you write again to the file before closing it
> (possible?!), and count is less the the previous count
> you may not pass a zero terminated string/data to store().

Yeah, that might happen, but writing to a sysfs file again after the
first time is not the normal case here.  I'll add your patch to the
queue to keep this from happening though, good catch.

greg k-h

  reply	other threads:[~2006-10-23 21:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-22 17:17 [PATCH] 2.6.19-rc2-mm2 sysfs: sysfs_write_file() writes zero terminated data Thomas Maier
2006-10-22 18:39 ` Greg KH
2006-10-23 20:02   ` Thomas Maier
2006-10-23 21:18     ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-10-26 12:08 balagi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061023211835.GA27613@suse.de \
    --to=gregkh@suse.de \
    --cc=balagi@justmail.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.