All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Parkins <andyparkins@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] git-cherry should show "+" instead of "-" and vice versa
Date: Mon, 23 Oct 2006 21:22:10 +0100	[thread overview]
Message-ID: <200610232122.17268.andyparkins@gmail.com> (raw)
In-Reply-To: <20061023193326.GS20017@pasky.or.cz>

[-- Attachment #1: Type: text/plain, Size: 803 bytes --]

On Monday 2006, October 23 20:33, Petr Baudis wrote:

> Did the documentation ever get fixed or noone cared enough? ;-)

My patch makes git-cherry match the documentation.

Personally I think that the documentation is correct.  git-cherry is, to me, 
terribly useful.  I've got a few patches in my own branch and it's very 
useful to be able to check to see if those emailed patches have been accepted 
upstream with a simple

git-cherry -v upstream

Which makes it natural to see
 "-" = patch not in upstream
 "+" = patch in upstream

I read the thread you pointed at, and didn't really understand what the downer 
on git-cherry was, or why the patch wasn't accepted.  Have I misunderstood 
something?



Andy
-- 
Dr Andrew Parkins, M Eng (Hons), AMIEE
andyparkins@gmail.com

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

      reply	other threads:[~2006-10-23 20:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-23 19:03 [PATCH] git-cherry should show "+" instead of "-" and vice versa Andy Parkins
2006-10-23 19:33 ` Petr Baudis
2006-10-23 20:22   ` Andy Parkins [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200610232122.17268.andyparkins@gmail.com \
    --to=andyparkins@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.