All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: kyungmin.park@samsung.com
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [patch 2.6.18-omap-git] omap2 fullspeed usb 2/2 (apollon)
Date: Tue, 24 Oct 2006 11:43:19 -0700	[thread overview]
Message-ID: <200610241143.20417.david-b@pacbell.net> (raw)
In-Reply-To: <001d01c6f65e$270c8b10$c7a3580a@swcenter.sec.samsung.co.kr>

On Sunday 22 October 2006 9:46 pm, Kyungmin Park wrote:
> [PATCH] USB device support on Apollon
>  
>   Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>


So this is what I sent but without the set_irq_type() stuff that somehow
got in, right?

Have you verified that it's stil behaving on your board?

- Dave


> ----
> 
> diff --git a/arch/arm/mach-omap2/board-apollon.c b/arch/arm/mach-
> omap2/board-apollon.c
> index 99651b2..e1e2246 100644
> --- a/arch/arm/mach-omap2/board-apollon.c
> +++ b/arch/arm/mach-omap2/board-apollon.c
> @@ -235,6 +235,13 @@ static struct omap_mmc_config apollon_mm
>  	},
>  };
>  
> +static struct omap_usb_config apollon_usb_config __initdata = {
> +	.register_dev	= 1,
> +	.hmc_mode	= 0x14,	/* 0:dev 1:host1 2:disable */
> +
> +	.pins[0]	= 6,
> +};
> +
>  static struct omap_lcd_config apollon_lcd_config __initdata = {
>  	.ctrl_name	= "internal",
>  };
> @@ -242,6 +249,7 @@ static struct omap_lcd_config apollon_lc
>  static struct omap_board_config_kernel apollon_config[] = {
>  	{ OMAP_TAG_UART,	&apollon_uart_config },
>  	{ OMAP_TAG_MMC,		&apollon_mmc_config },
> +	{ OMAP_TAG_USB,		&apollon_usb_config },
>  	{ OMAP_TAG_LCD,		&apollon_lcd_config },
>  };
>  
> @@ -310,11 +318,22 @@ static void __init apollon_sw_init(void)
>  		return;
>  }
>  
> +static void __init apollon_usb_init(void)
> +{
> +	/* USB device */
> +	/* DEVICE_SUSPEND */
> +	omap_cfg_reg(P21_242X_GPIO12);
> +	omap_request_gpio(12);
> +	omap_set_gpio_direction(12, 0);		/* OUT */
> +	omap_set_gpio_dataout(12, 0);
> +}
> +
>  static void __init omap_apollon_init(void)
>  {
>  	apollon_led_init();
>  	apollon_sw_init();
>  	apollon_flash_init();
> +	apollon_usb_init();
>  
>  	/* REVISIT: where's the correct place */
>  	omap_cfg_reg(W19_24XX_SYS_NIRQ);
> 

  reply	other threads:[~2006-10-24 18:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-20 19:52 [patch 2.6.18-omap-git] omap2 fullspeed usb 2/2 (apollon) David Brownell
2006-10-23  4:46 ` Kyungmin Park
2006-10-24 18:43   ` David Brownell [this message]
2006-10-25 18:46     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200610241143.20417.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.