diff for duplicates of <200610242107.44115.arnd@arndb.de> diff --git a/a/1.txt b/N1/1.txt index d7a1e84..f390a27 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,13 +1,12 @@ On Tuesday 24 October 2006 20:42, Pekka Enberg wrote: > On 10/24/06, Arnd Bergmann <arnd@arndb.de> wrote: -> > =A0 =A0 =A0 =A0 spu_acquire(ctx); -> > - =A0 =A0 =A0 for (count =3D 0; count <=3D len; count +=3D 4, udata++) { -> > + =A0 =A0 =A0 for (count =3D 0; (count + 4) <=3D len; count +=3D 4, uda= -ta++) { +> > spu_acquire(ctx); +> > - for (count = 0; count <= len; count += 4, udata++) { +> > + for (count = 0; (count + 4) <= len; count += 4, udata++) { > > Wouldn't this be more obvious as > -> =A0 for (count =3D 0, count < (len / 4); count++, udata++) { +> for (count = 0, count < (len / 4); count++, udata++) { > > And then do count * 4 if you need the actual index somewhere. Hmm? @@ -15,4 +14,4 @@ Count is the return value from a write() file operation. I find it more readable to update that every time I do one put_user(), to the exact value, than calculating the return code later. - Arnd <><=20 + Arnd <>< diff --git a/a/content_digest b/N1/content_digest index c5571a9..2cef76e 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -5,23 +5,22 @@ "Subject\0Re: [PATCH 2/3] spufs: fix another off-by-one bug in mbox_read\0" "Date\0Tue, 24 Oct 2006 21:07:43 +0200\0" "To\0Pekka Enberg <penberg@cs.helsinki.fi>\0" - "Cc\0linuxppc-dev@ozlabs.org" - Paul Mackerras <paulus@samba.org> + "Cc\0Paul Mackerras <paulus@samba.org>" + linuxppc-dev@ozlabs.org cbe-oss-dev@ozlabs.org - Arnd Bergmann <arnd@arndb.de> - " linux-kernel@vger.kernel.org\0" + linux-kernel@vger.kernel.org + " Arnd Bergmann <arnd@arndb.de>\0" "\00:1\0" "b\0" "On Tuesday 24 October 2006 20:42, Pekka Enberg wrote:\n" "> On 10/24/06, Arnd Bergmann <arnd@arndb.de> wrote:\n" - "> > =A0 =A0 =A0 =A0 spu_acquire(ctx);\n" - "> > - =A0 =A0 =A0 for (count =3D 0; count <=3D len; count +=3D 4, udata++) {\n" - "> > + =A0 =A0 =A0 for (count =3D 0; (count + 4) <=3D len; count +=3D 4, uda=\n" - "ta++) {\n" + "> > \302\240 \302\240 \302\240 \302\240 spu_acquire(ctx);\n" + "> > - \302\240 \302\240 \302\240 for (count = 0; count <= len; count += 4, udata++) {\n" + "> > + \302\240 \302\240 \302\240 for (count = 0; (count + 4) <= len; count += 4, udata++) {\n" ">\n" "> Wouldn't this be more obvious as\n" ">\n" - "> =A0 for (count =3D 0, count < (len / 4); count++, udata++) {\n" + "> \302\240 for (count = 0, count < (len / 4); count++, udata++) {\n" ">\n" "> And then do count * 4 if you need the actual index somewhere. Hmm?\n" "\n" @@ -29,6 +28,6 @@ "more readable to update that every time I do one put_user(), to\n" "the exact value, than calculating the return code later.\n" "\n" - "\tArnd <><=20" + "\tArnd <><" -d475610e846d6cd7e0f6e20943c20507fa5bc3ae79087966487ad73529f248ad +ba1cbdd2f8399a994b0d1b91781b073c7777cfc72c3959c66ac6678cbcb88a6b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.