From: Ryan Jackson <rjackson@lnxi.com>
To: Artem Bityutskiy <dedekind@infradead.org>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] [PATCH] [MTD] MAPS: Support for BIOS flash chips on the nvidia ck804 southbridge
Date: Wed, 25 Oct 2006 10:43:31 -0600 [thread overview]
Message-ID: <20061025164331.GE25530@localdomain> (raw)
In-Reply-To: <1161776104.3260.201.camel@sauron>
* Artem Bityutskiy <dedekind@infradead.org> [061025 05:35]:
> > + * $Id: ck804xrom.c,v 1.1 2005/01/06 16:58:24 dolsen Exp $
> No need to dubmit CVS stuff
Oops.
> Also it would be nice to add your name at the header.
Sure, but I'm not the original author. I'll put his name in as well as
mine.
> > +#include <linux/config.h>
> Don't include this file - this stuff is done by the Linux build system.
Didn't catch that. I'll remove it.
> > +#define ROM_PROBE_STEP_SIZE (64*1024) /* 64KiB */
> I personally would be happier to see a comment about what this macro is,
> not about that 64*1024 = 64KiB.
Sure.
> {} for one-line operators are not needed as well as all over the code -
> that's a linux coding style convention.
> Please, use } else { instead.
No problem. I should have checked for this already.
Thanks.
--
Ryan Jackson
Linux Networx
next prev parent reply other threads:[~2006-10-25 16:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-24 17:46 [PATCH] [PATCH] [MTD] MAPS: Support for BIOS flash chips on the nvidia ck804 southbridge Ryan Jackson
2006-10-25 11:35 ` Artem Bityutskiy
2006-10-25 16:43 ` Ryan Jackson [this message]
2006-10-25 12:39 ` David Woodhouse
2006-10-25 17:36 ` Ryan Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061025164331.GE25530@localdomain \
--to=rjackson@lnxi.com \
--cc=dedekind@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.