From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Daniel P. Berrange" Subject: Re: [PATCH][Take 4] VNC authentification Date: Wed, 25 Oct 2006 19:00:37 +0100 Message-ID: <20061025180037.GC18644@redhat.com> References: <4524583D.8000109@us.ibm.com> <20061010131116.GA22928@redhat.com> <452BA859.2060306@us.ibm.com> Reply-To: "Daniel P. Berrange" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <452BA859.2060306@us.ibm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Anthony Liguori Cc: Ian Pratt , xen-devel@lists.xensource.com, Masami Watanabe List-Id: xen-devel@lists.xenproject.org Hi Kier / Ewan, Can we get Masami's VNC password patch into xen-unstable. Regards, Dan On Tue, Oct 10, 2006 at 09:04:09AM -0500, Anthony Liguori wrote: > Daniel P. Berrange wrote: > >On Thu, Oct 05, 2006 at 10:28:15AM +0900, Masami Watanabe wrote: > > > >>Hi all, > >> > >>This is take 4 on VNC authentification. > >> > >>The specification is as mentioned at > >>http://lists.xensource.com/archives/html/xen-devel/2006-09/msg00666.html > >>(However, password came to describe plain text) > >> > >>The difference is follows. > >>- protocol_authtype() without the necessity was deleted. > >>- The check on the protocol version was added. > >>- And, some small modification. > >> > > > >The patch loooks good to me - unless Anthony spots any further issues in > >the VNC auth code, I'd say this is worth commiting to xen-unstable.hg > >whe 3.0.4 development opens up. > > > > Looks good to me too. Thanks Masami! -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|