All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Landley <rob@landley.net>
To: qemu-devel@nongnu.org
Cc: Andreas Schwab <schwab@suse.de>, Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] Fix char signedness
Date: Sat, 28 Oct 2006 14:58:33 -0400	[thread overview]
Message-ID: <200610281458.33806.rob@landley.net> (raw)
In-Reply-To: <200610280009.17673.paul@codesourcery.com>

On Friday 27 October 2006 7:09 pm, Paul Brook wrote:
> > > > It has been a really long time I have been working on a broken system
> > > > that did not default to "signed".
> > >
> > > The only thing that is broken is your knowlege of C.
> >
> > Okay.
> >
> > And what system did you encounter this behaviour on?
> 
> Common arm, ppc, s390 and mips systems all have default char as unsigned.
> As do a few other less common embedded systems.

BusyBox added "-funsigned-char" to our build to get consistent behavior.  (I 
picked unsigned because that way we were automatically 8-bit clean in things 
like sed.)

(I note that tcc doesn't work right if built with -funsigned-char, so I 
wouldn't be too surprised if qemu had the same problem.)  In both cases, 
specifying -fsigned-char in the build should fix it.

> Paul

Rob
-- 
"Perfection is reached, not when there is no longer anything to add, but
when there is no longer anything to take away." - Antoine de Saint-Exupery

  reply	other threads:[~2006-10-28 18:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-27 17:07 [Qemu-devel] [PATCH] Fix char signedness Andreas Schwab
2006-10-27 17:40 ` Johannes Schindelin
2006-10-27 17:54   ` andrzej zaborowski
2006-10-27 17:58   ` Andreas Schwab
2006-10-27 18:23     ` M. Warner Losh
2006-10-28 10:46       ` Martin Guy
2006-10-28 19:04         ` Rob Landley
2006-10-27 22:57     ` Johannes Schindelin
2006-10-27 23:09       ` Paul Brook
2006-10-28 18:58         ` Rob Landley [this message]
2006-10-27 23:12       ` Thiemo Seufer
2006-10-27 23:17       ` M. Warner Losh
2006-10-28 10:14       ` Laurent Desnogues

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200610281458.33806.rob@landley.net \
    --to=rob@landley.net \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.