All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Schwinge <tschwinge@gnu.org>
To: "Yoshinori K. Okuji" <okuji@enbug.org>
Cc: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Conditionally building `grub-emu'
Date: Sat, 28 Oct 2006 17:32:05 +0200	[thread overview]
Message-ID: <20061028153205.GY6928@fencepost> (raw)
In-Reply-To: <200610281547.09771.okuji@enbug.org>

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]

Hello!

On Sat, Oct 28, 2006 at 03:47:09PM +0200, Yoshinori K. Okuji wrote:
> On Sunday 22 October 2006 16:46, Thomas Schwinge wrote:
> > As `grub-emu' is considered to ``only'' be a debugging tool, the
> > patch disables it for a default build (and thusly also avoids the
> > (n)curses dependency for a default build).
> 
> This patch is good. But we need a copyright assignment to apply it. I will 
> send another mail to you later.

This is in process now.


> > Running `make grub_script.tab.h' and then again `make' makes the build
> > succeed.  So my guess is that there is a missing dependency somewhere and
> > it wasn't a problem so far because the file was built earlier (for
> > `grub-emu'?).  Someone who knows the dependencies between the source
> > files should be able to quickly spot the missing one.
> 
> For this problem, I think we should remove the inclusion of script.h in 
> normal.h, and add a dependency explicitly to normal.mod. I'll try.

The patch you applied indeed does fix this problem.  Thanks.


Regards,
 Thomas

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2006-10-28 15:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-22 14:46 Conditionally building `grub-emu' Thomas Schwinge
2006-10-26 18:59 ` Hollis Blanchard
2006-10-28 13:47 ` Yoshinori K. Okuji
2006-10-28 15:32   ` Thomas Schwinge [this message]
2006-12-13 13:31   ` Thomas Schwinge
2006-12-13 21:46     ` Yoshinori K. Okuji
2006-12-13 22:35       ` Thomas Schwinge
2006-12-14 12:19 ` Marco Gerards
2006-12-15  9:40   ` Thomas Schwinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061028153205.GY6928@fencepost \
    --to=tschwinge@gnu.org \
    --cc=grub-devel@gnu.org \
    --cc=okuji@enbug.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.