All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Pierre Ossman <drzeus-list@drzeus.cx>
Cc: Carlos Aguiar <carlos.aguiar@indt.org.br>,
	linux-kernel@vger.kernel.org,
	linux-omap-open-source@linux.omap.com,
	Tony Lindgren <tony@atomide.com>,
	Russell King <rmk+lkml@arm.linux.org.uk>,
	ilias.biris@indt.org.br
Subject: Re: [patch 3/6] [RFC] Add MMC Password Protection (lock/unlock) support V5
Date: Sun, 29 Oct 2006 19:06:50 -0700	[thread overview]
Message-ID: <200610291806.56131.david-b@pacbell.net> (raw)
In-Reply-To: <45447914.7070101@drzeus.cx>

On Sunday 29 October 2006 1:49 am, Pierre Ossman wrote:

> > +	data_buf = kmalloc(data_size, GFP_KERNEL);
> >   
> 
> For something that can be at most 34 bytes, a kmalloc seems excessive.
> Put it on the stack. Just remember to have checks so we do not overflow.

It does seem excessive, but stack-allocated buffers are not guaranteed
to be DMA-safe.  See Documentation/DMA-mapping.txt right in the first
major section "What memory is DMA'able?"...

  reply	other threads:[~2006-10-30  2:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20061020164914.012378000@localhost.localdomain>
2006-10-23  6:03 ` [patch 0/6] [RFC] Add MMC Password Protection (lock/unlock) support V5 Pierre Ossman
2006-10-23 16:44   ` Russell King
     [not found] ` <20061020165131.681329000@localhost.localdomain>
2006-10-29  9:26   ` [patch 1/6] " Pierre Ossman
     [not found] ` <20061020165134.378993000@localhost.localdomain>
2006-10-29  9:31   ` [patch 2/6] " Pierre Ossman
     [not found] ` <20061020165135.162482000@localhost.localdomain>
2006-10-29  9:49   ` [patch 3/6] " Pierre Ossman
2006-10-30  2:06     ` David Brownell [this message]
     [not found] ` <20061020165135.852337000@localhost.localdomain>
2006-10-29  9:52   ` [patch 4/6] " Pierre Ossman
     [not found] ` <20061020165136.664879000@localhost.localdomain>
2006-10-29  9:57   ` [patch 5/6] " Pierre Ossman
     [not found] ` <20061020165139.911232000@localhost.localdomain>
2006-10-29  9:57   ` [patch 6/6] " Pierre Ossman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200610291806.56131.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=carlos.aguiar@indt.org.br \
    --cc=drzeus-list@drzeus.cx \
    --cc=ilias.biris@indt.org.br \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap-open-source@linux.omap.com \
    --cc=rmk+lkml@arm.linux.org.uk \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.