From: Matthew Wilcox <matthew@wil.cx>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] cleaning of HANDLE_STACK definition
Date: Sun, 29 Oct 2006 19:36:30 +0000 [thread overview]
Message-ID: <20061029193630.GW5591@parisc-linux.org> (raw)
In-Reply-To: <20061029191459.92665.qmail@web90313.mail.mud.yahoo.com>
On Sun, Oct 29, 2006 at 11:14:59AM -0800, Giangiacomo Mariotti wrote:
> This little patch cleans the definition of HANDLE_STACK in arch/x86_64/kernel/traps.c because it's syntax is misleading.
Yeah, but you've wrapped it past the 80 column boundary, so you'd need
to fix that. And you didn't put a Signed-off-by on it.
I don't think the outer do ... while is necessary anyway. Is there any
problem with just deleting them?
> #define HANDLE_STACK(cond) \
> - do while (cond) { \
> - unsigned long addr = *stack++; \
> - if (oops_in_progress ? \
> - __kernel_text_address(addr) : \
> - kernel_text_address(addr)) { \
> - /* \
> - * If the address is either in the text segment of the \
> - * kernel, or in the region which contains vmalloc'ed \
> - * memory, it *may* be the address of a calling \
> - * routine; if so, print it so that someone tracing \
> - * down the cause of the crash will be able to figure \
> - * out the call path that was taken. \
> - */ \
> - ops->address(data, addr); \
> + do { \
> + while (cond) { \
> + unsigned long addr = *stack++; \
> + if (oops_in_progress ? \
> + __kernel_text_address(addr) : \
> + kernel_text_address(addr)) { \
> + /* \
> + * If the address is either in the text segment of the \
> + * kernel, or in the region which contains vmalloc'ed \
> + * memory, it *may* be the address of a calling \
> + * routine; if so, print it so that someone tracing \
> + * down the cause of the crash will be able to figure \
> + * out the call path that was taken. \
> + */ \
> + ops->address(data, addr); \
> + } \
> } \
> } while (0)
>
> --
> 1.4.3.2
>
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.osdl.org
> https://lists.osdl.org/mailman/listinfo/kernel-janitors
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2006-10-29 19:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-29 19:14 [KJ] [PATCH] cleaning of HANDLE_STACK definition Giangiacomo Mariotti
2006-10-29 19:36 ` Matthew Wilcox [this message]
2006-10-29 20:11 ` Giangiacomo Mariotti
2006-10-29 22:41 ` Giangiacomo Mariotti
2006-10-30 3:12 ` Amit Choudhary
2006-10-30 12:07 ` Darren Jenkins
2006-10-30 12:22 ` Giangiacomo Mariotti
2006-10-30 12:52 ` Jaco Kroon
2006-10-30 13:26 ` Giangiacomo Mariotti
2006-10-30 13:42 ` Jaco Kroon
2006-10-30 13:46 ` Giangiacomo Mariotti
2006-10-30 13:52 ` Giangiacomo Mariotti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061029193630.GW5591@parisc-linux.org \
--to=matthew@wil.cx \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.