From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH/RFC (take 2)] gitweb: New improved patchset view
Date: Mon, 30 Oct 2006 02:21:58 +0100 [thread overview]
Message-ID: <200610300221.58782.jnareb@gmail.com> (raw)
In-Reply-To: <7vr6wqy5cb.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> Jakub Narebski <jnareb@gmail.com> writes:
>> 3. Should we make from-range/to-range in chunk header hyperlink to the
>> start of given bunch of lines in appropriate file? Or perhaps to the
>> middle of the bunch of lines? Or to first changed line (omitting
>> context)?
>
> I do not see what usage pattern this link would help. Care to
> explain a bit better?
For example for the following header
diff --git _a/gitweb/gitweb.perl_ _b/gitweb/gitweb.perl_
index _cbab3c9_.._a5a140c_ 100755
--- a/_gitweb/gitweb.perl_
+++ b/_gitweb/gitweb.perl_
@@ _-1255,9_ _+1255,12_ @@ sub parse_difftree_raw_line {
The '-1255,9' would be link to older version of gitweb/gitweb.perl file,
directly to the line #1255 (or to first changed line, or to the middle
of the chunk i.e. 1255+9/2 line).
The '+1255,12' would be link to newer version of file, to line 1255.
--
Jakub Narebski
next prev parent reply other threads:[~2006-10-30 1:22 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-29 10:22 [PATCH/RFC] gitweb: New improved patchset view Jakub Narebski
2006-10-29 11:47 ` Junio C Hamano
2006-10-29 12:24 ` Jakub Narebski
2006-10-29 12:48 ` Jakub Narebski
2006-10-29 15:35 ` Jakub Narebski
2006-10-29 19:43 ` Luben Tuikov
2006-10-29 20:19 ` Jakub Narebski
2006-10-29 22:05 ` Jakub Narebski
2006-10-29 20:29 ` Junio C Hamano
2006-10-29 19:33 ` Luben Tuikov
2006-10-29 12:44 ` Anand Kumria
2006-10-29 19:38 ` Luben Tuikov
2006-10-29 17:50 ` Jakub Narebski
2006-10-29 18:49 ` Junio C Hamano
2006-10-30 1:43 ` Luben Tuikov
2006-10-29 19:55 ` Luben Tuikov
2006-10-29 20:29 ` Jakub Narebski
2006-10-29 19:31 ` Luben Tuikov
2006-10-29 23:51 ` [PATCH/RFC (take 2)] " Jakub Narebski
2006-10-30 0:34 ` Jakub Narebski
2006-10-30 1:12 ` Junio C Hamano
2006-10-30 1:21 ` Jakub Narebski [this message]
2006-10-30 1:59 ` Luben Tuikov
2006-10-30 8:05 ` Jakub Narebski
2006-10-30 8:21 ` Junio C Hamano
2006-10-30 8:51 ` Junio C Hamano
2006-10-30 9:43 ` Jakub Narebski
2006-10-30 13:58 ` Jakub Narebski
2006-10-30 22:59 ` Junio C Hamano
2006-10-30 23:32 ` Jakub Narebski
2006-10-30 23:40 ` Junio C Hamano
2006-10-30 21:34 ` Luben Tuikov
2006-10-30 21:50 ` Jakub Narebski
2006-10-30 22:30 ` Edgar Toernig
2006-10-30 22:39 ` Jakub Narebski
2006-10-31 22:41 ` Edgar Toernig
2006-10-30 22:40 ` Luben Tuikov
2006-10-30 23:00 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610300221.58782.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.