From: rmccabe@sourceware.org <rmccabe@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] conga/luci cluster/resource_form_handlers.js h ...
Date: 30 Oct 2006 21:21:18 -0000 [thread overview]
Message-ID: <20061030212118.3402.qmail@sourceware.org> (raw)
CVSROOT: /cvs/cluster
Module name: conga
Changes by: rmccabe at sourceware.org 2006-10-30 21:21:17
Modified files:
luci/cluster : resource_form_handlers.js
luci/homebase : form-macros
luci/site/luci/Extensions: ricci_bridge.py
Log message:
- fix for javascript FS resource validation (would always say you had not selected a FS type)
- fix for batchAttemptResult function decl: callers expect to pass only one argument
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/luci/cluster/resource_form_handlers.js.diff?cvsroot=cluster&r1=1.20&r2=1.21
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/luci/homebase/form-macros.diff?cvsroot=cluster&r1=1.45&r2=1.46
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/luci/site/luci/Extensions/ricci_bridge.py.diff?cvsroot=cluster&r1=1.36&r2=1.37
--- conga/luci/cluster/resource_form_handlers.js 2006/10/07 20:12:47 1.20
+++ conga/luci/cluster/resource_form_handlers.js 2006/10/30 21:21:16 1.21
@@ -140,7 +140,7 @@
function validate_filesystem(form) {
var errors = new Array();
- if (!form.fsTypeSelect || str_is_blank(form.fsTypeSelect.value)) {
+ if (!form.fstype || str_is_blank(form.fstype.value)) {
errors.push('No file system type was given.');
set_form_err(form.fsTypeSelect);
} else
--- conga/luci/homebase/form-macros 2006/10/30 20:42:03 1.45
+++ conga/luci/homebase/form-macros 2006/10/30 21:21:16 1.46
@@ -1,7 +1,7 @@
<html>
<tal:comment tal:replace="nothing">
- $Id: form-macros,v 1.45 2006/10/30 20:42:03 rmccabe Exp $
+ $Id: form-macros,v 1.46 2006/10/30 21:21:16 rmccabe Exp $
</tal:comment>
<head>
@@ -560,8 +560,6 @@
<tal:block tal:condition="python: not request.SESSION.has_key('checkRet')"
tal:define="global sessionObj python:{}" />
- <tal:block tal:define="
-
<h2 class="homebase">Add Cluster</h2>
<form name="adminform" action="" method="post"
--- conga/luci/site/luci/Extensions/ricci_bridge.py 2006/10/26 22:59:13 1.36
+++ conga/luci/site/luci/Extensions/ricci_bridge.py 2006/10/30 21:21:17 1.37
@@ -206,7 +206,7 @@
return minidom.parseString(batch).firstChild
-def batchAttemptResult(self, doc):
+def batchAttemptResult(doc):
try:
batch = doc.getElementsByTagName('batch')
if not batch or len(batch) < 1:
next reply other threads:[~2006-10-30 21:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-30 21:21 rmccabe [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-09-29 21:41 [Cluster-devel] conga/luci cluster/resource_form_handlers.js h rmccabe
2006-09-25 17:36 rmccabe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061030212118.3402.qmail@sourceware.org \
--to=rmccabe@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.