From: Shawn Pearce <spearce@spearce.org>
To: Junio C Hamano <junkio@cox.net>
Cc: Nicolas Pitre <nico@cam.org>, git@vger.kernel.org
Subject: Re: WARNING: THIS PATCH CAN BREAK YOUR REPO, was Re: [PATCH 2/3] Only repack active packs by skipping over kept packs.
Date: Mon, 30 Oct 2006 16:55:29 -0500 [thread overview]
Message-ID: <20061030215529.GC5775@spearce.org> (raw)
In-Reply-To: <7v7iyhwk47.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> wrote:
> Shawn Pearce <spearce@spearce.org> writes:
>
> > Do the above so you have everything in one pack. Now use rev-list
> > to simulate the object list construction in pack-objects as though
> > we were doing a 'git repack -a -d':
> >
> > git-rev-list --objects --all \
> > --unpacked=.git/objects/pack/pack-*.pack \
> > | wc -l
> >
> > gives me 102 (WRONG WRONG WRONG WRONG!!!!!!)
>
> Now I think I know what is going on.
>
> The meaning of "unpacked" (with or without the "pretend as if
> all objects in this pack are loose") has always been to stop
> traversing once we hit a packed object, not "do not include
> already packed object".
Did you see Jan Harkes' patch that changes the behavior to be what
it should have been?
> So --unpacked=pretend-this-is-loose was wrong to begin with; it
> probably should have been --incremental=pretend-this-is-loose.
I don't care about what the option name is. If you want to change
it to --incremental we can but the --unpacked actually makes more
sense now... Its saying pretend every object in this pack is
unpacked and therefore should be packed.
> How about reverting the following:
>
> commit ce8590748b918687abc4c7cd2d432dd23f07ae40
> Author: Shawn Pearce <spearce@spearce.org>
>
> Only repack active packs by skipping over kept packs.
>
>
> commit 106d710bc13f34aec1a15c4cff80f062f384edf6
> Author: Junio C Hamano <junkio@cox.net>
>
> pack-objects --unpacked=<existing pack> option.
>
Nah. I think Jan's patch fixes the bug and the --unpacked option
now makes sense as is, so I don't see why we would revert these.
--
next prev parent reply other threads:[~2006-10-30 21:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-29 9:37 [PATCH 2/3] Only repack active packs by skipping over kept packs Shawn Pearce
2006-10-30 19:07 ` WARNING: THIS PATCH CAN BREAK YOUR REPO, was " Nicolas Pitre
2006-10-30 19:23 ` Shawn Pearce
2006-10-30 20:26 ` Shawn Pearce
2006-10-30 20:52 ` Jan Harkes
2006-10-30 21:07 ` Jan Harkes
2006-10-30 21:09 ` Shawn Pearce
2006-10-30 21:59 ` Junio C Hamano
2006-10-30 22:54 ` Junio C Hamano
2006-10-30 22:55 ` Jan Harkes
2006-10-30 23:24 ` Junio C Hamano
2006-10-31 1:37 ` [PATCH] Continue traversal when rev-list --unpacked finds a packed commit Jan Harkes
2006-10-31 1:47 ` Junio C Hamano
2006-10-31 2:17 ` Jan Harkes
2006-10-30 21:48 ` WARNING: THIS PATCH CAN BREAK YOUR REPO, was Re: [PATCH 2/3] Only repack active packs by skipping over kept packs Junio C Hamano
2006-10-30 21:55 ` Shawn Pearce [this message]
2006-10-30 22:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061030215529.GC5775@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.