From: Horst Schirmeier <horst@schirmeier.com>
To: Oleg Verych <olecom@flower.upol.cz>
Cc: Valdis.Kletnieks@vt.edu, Jan Beulich <jbeulich@novell.com>,
dsd@gentoo.org, kernel@gentoo.org, draconx@gmail.com,
jpdenheijer@gmail.com, Andrew Morton <akpm@osdl.org>,
Sam Ravnborg <sam@ravnborg.org>, Andi Kleen <ak@suse.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -mm] replacement for broken kbuild-dont-put-temp-files-in-the-source-tree.patch
Date: Tue, 31 Oct 2006 01:27:57 +0100 [thread overview]
Message-ID: <20061031002757.GF2933@quickstop.soohrt.org> (raw)
In-Reply-To: <slrnekcu6m.2vm.olecom@flower.upol.cz>
On Mon, 30 Oct 2006, Oleg Verych wrote:
> +# Immortal null for mortals and roots
> +define null
> + $(shell \
> + if test -L null; \
> + then echo null; \
> + else rm -f null; ln -s /dev/null null; \
> + fi)
> +endef
Another remark: the 'else' branch should echo null, too.
# Immortal null for mortals and roots
define null
$(shell \
if test ! -L null; \
then rm -f null; ln -s /dev/null null; \
fi; \
echo null)
endef
My patch proposal (the $(M) one) has the same bug.
Kind regards,
Horst
--
PGP-Key 0xD40E0E7A
next prev parent reply other threads:[~2006-10-31 0:27 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-28 23:07 [PATCH -mm] replacement for broken kbuild-dont-put-temp-files-in-the-source-tree.patch Horst Schirmeier
2006-10-29 2:07 ` Andi Kleen
2006-10-29 12:08 ` Horst Schirmeier
2006-10-29 16:16 ` Andi Kleen
2006-10-29 17:52 ` Oleg Verych
2006-10-29 22:52 ` Sam Ravnborg
2006-10-30 8:16 ` Jan Beulich
2006-10-30 13:16 ` Oleg Verych
[not found] ` <45460E6C.76E4.0078.0@novell.com>
2006-10-30 14:42 ` Oleg Verych
2006-10-30 15:22 ` Valdis.Kletnieks
2006-10-30 16:06 ` Oleg Verych
2006-10-30 22:12 ` Oleg Verych
2006-10-31 0:12 ` Horst Schirmeier
2006-10-31 0:19 ` Andi Kleen
2006-10-31 1:14 ` Horst Schirmeier
2006-10-31 13:51 ` Oleg Verych
2006-11-02 12:46 ` Jan Peter den Heijer
2006-11-17 5:17 ` kbuild: O= with M= (Re: [PATCH -mm] replacement for broken kbuild-dont-put-temp-files-in-the-source-tree.patch) Oleg Verych
2007-01-23 7:36 ` [fix, rfc] " Oleg Verych
2007-01-24 8:54 ` [patch] kbuild: improving option checking " Oleg Verych
2007-01-24 16:06 ` Randy Dunlap
2007-01-24 19:28 ` [patch] spell 4 kbuild: improving option checking Oleg Verych
2006-10-31 0:27 ` Horst Schirmeier [this message]
2006-10-31 13:32 ` [PATCH -mm] replacement for broken kbuild-dont-put-temp-files-in-the-source-tree.patch Oleg Verych
2006-11-15 14:17 ` kbuild-mm: $(objtree)/knull vs mktemp (was Re: [PATCH -mm] replacement for broken kbuild-dont-put-temp-files-in-the-source-tree.patch) Oleg Verych
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061031002757.GF2933@quickstop.soohrt.org \
--to=horst@schirmeier.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=draconx@gmail.com \
--cc=dsd@gentoo.org \
--cc=jbeulich@novell.com \
--cc=jpdenheijer@gmail.com \
--cc=kernel@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olecom@flower.upol.cz \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.