From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tony Breeds <tony@bakeyournoodle.com>
Subject: Re: [PATCH] [XM-TEST] Fix xm-test suite for x86-64
Date: Tue, 31 Oct 2006 11:42:14 +1100
Message-ID: <20061031004214.GK27551@bakeyournoodle.com>
References: <20061030031743.GF27551@bakeyournoodle.com>
	<OF8CDA98FD.4FD47460-ON85257217.004F36B5-85257217.0050FF32@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <OF8CDA98FD.4FD47460-ON85257217.004F36B5-85257217.0050FF32@us.ibm.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Stefan Berger <stefanb@us.ibm.com>
Cc: xen-devel <xen-devel@lists.xensource.com>, xen-devel-bounces@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On Mon, Oct 30, 2006 at 09:44:52AM -0500, Stefan Berger wrote:
 
> I have changed the xm-test/ramdisk/Makefile.am to look like this now. With 
> this only x86-64 so far gets its own config for the uClibc.
> 
> -                cp configs/uClibc $(BR_SRC)/toolchain/uClibc/uClibc.config
> +                if [ $(BR_ARCH) == "x86_64" ]; then \
> +                                cp configs/uClibc-$(BR_ARCH)         \
> + $(BR_SRC)/toolchain/uClibc/uClibc.config; \
> +                else \
> +                                cp configs/uClibc         \
> + $(BR_SRC)/toolchain/uClibc/uClibc.config; \
> +                fi
> 
> Is this better?

Personally I prefer your original approach.  Sure it creates duplicate
data files (as i386 and powerpc uClibc are the same) but it follows the
buildroot precident, and allows for changing configs based on the arch
without modifying the Makefiles.
 
> http://bugs.busybox.net/bug_view_advanced_page.php?bug_id=523

Bugger.  I wonder what the timeframe is for the next uClibc release.
 
> And thanks on the hint on how to patch hping2. It works now - at least for 
> x86-64.

Glad it helped.

Yours Tony

   linux.conf.au       http://linux.conf.au/ || http://lca2007.linux.org.au/
   Jan 15-20 2007      The Australian Linux Technical Conference!