From: Jens Axboe <jens.axboe@oracle.com>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: Dave Kleikamp <shaggy@austin.ibm.com>,
Daniel Drake <ddrake@brontes3d.com>,
axboe@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] jfs: Add splice support
Date: Tue, 31 Oct 2006 09:46:04 +0100 [thread overview]
Message-ID: <20061031084604.GB14055@kernel.dk> (raw)
In-Reply-To: <Pine.LNX.4.61.0610310931020.23540@yvahk01.tjqt.qr>
On Tue, Oct 31 2006, Jan Engelhardt wrote:
>
> >> This allows the splice() and tee() syscalls to be used with JFS.
> >
> >Gosh, that was easy. Why couldn't I do that? :-)
>
> You could add it to all the other filesystems that lack it. (Cautionary
> question: Does that work at an instant like it did with jfs?)
>
> Seems like only ext[234] gfs2 reiserfs and xfs have splice_read
> currently.
If the file system uses the generic page cache functions for reading and
writing, it should be able to use the generic splice read/write
functions as well. If it doesn't, then more work is likely involved. In
short, check the .read/.write and .aio_read/.aio_write parts of the
file_operations[] structure. jfs uses the generic handlers, hence splice
support should just be the two-liner posted.
--
Jens Axboe
prev parent reply other threads:[~2006-10-31 8:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-30 16:31 [PATCH] jfs: Add splice support Daniel Drake
2006-10-30 16:56 ` Dave Kleikamp
2006-10-30 17:29 ` Daniel Drake
2006-10-30 17:49 ` Dave Kleikamp
2006-10-31 8:32 ` Jan Engelhardt
2006-10-31 8:46 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061031084604.GB14055@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=axboe@suse.de \
--cc=ddrake@brontes3d.com \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=shaggy@austin.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.