Re: [PATCH 1/2] libfsimage

[Tim Deegan <Tim.Deegan@xensource.com>]

At 19:58 +0100 on 27 Oct (1161979127), John Levon wrote:
> These two patches re-work pygrub to use a generic C library for reading
> filesystem images. An immediate benefit is that there's no longer any
> external dependencies, so all the filesystems always 'just work'.

This is a big step in the right direction.  Especially for pygrub, using
the same fs codebase that normal grub does seems like the right thing to
do.

> It also adds Solaris UFS support. The current plugins are all based on
> slightly modified Grub legacy code (so far it's taken about an hour to
> get a new FS from the grub code working).

>From a quick glance through, the changes you've made to the grub fs code
seem to be mostly eliminating grub's world of static block-access
variables and functions.  Could that be abstracted out into a wrapper
file that would let any grub filesystem code be used verbatim?  That
would reduce the maintenance load even further (and give us FAT and
ISO9660 for free).

Alternatively, how far away from stable enough are the grub2 drivers?

Cheers,

Tim.