[KJ] [PATCH] lib/string.c: Two if-clauses merged

[KJ] [PATCH] lib/string.c: Two if-clauses merged

[Andi Drebes]

The patch just deletes two lines of code and nothing else. Tested by 
compilation.

Signed-off-by: Andi Drebes <webmaster@programmierforen.de>

--- linux/lib/string.c	2006-10-14 05:34:03.000000000 +0200
+++ patched/lib/string.c	2006-10-28 18:21:11.000000000 +0200
@@ -43,9 +43,7 @@
 			c2 = *s2;
 			s1++;
 			s2++;
-			if (!c1)
-				break;
-			if (!c2)
+			if (!c1 || !c2)
 				break;
 			if (c1 = c2)
 				continue;
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] lib/string.c: Two if-clauses merged

[Alexey Dobriyan]

On Sat, Oct 28, 2006 at 06:30:18PM +0200, Andi Drebes wrote:
> The patch just deletes two lines of code and nothing else. Tested by
> compilation.

> --- linux/lib/string.c
> +++ patched/lib/string.c
> @@ -43,9 +43,7 @@
>  			c2 = *s2;
>  			s1++;
>  			s2++;
> -			if (!c1)
> -				break;
> -			if (!c2)
> +			if (!c1 || !c2)
>  				break;

Hmm... There are probably thousands of places like this. And checking
one thing at a time is in many cases better than one long check.

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] lib/string.c: Two if-clauses merged

[Adrian Bunk]

On Sat, Oct 28, 2006 at 10:12:57PM +0400, Alexey Dobriyan wrote:
> On Sat, Oct 28, 2006 at 06:30:18PM +0200, Andi Drebes wrote:
> > The patch just deletes two lines of code and nothing else. Tested by
> > compilation.
> 
> > --- linux/lib/string.c
> > +++ patched/lib/string.c
> > @@ -43,9 +43,7 @@
> >  			c2 = *s2;
> >  			s1++;
> >  			s2++;
> > -			if (!c1)
> > -				break;
> > -			if (!c2)
> > +			if (!c1 || !c2)
> >  				break;
> 
> Hmm... There are probably thousands of places like this. And checking
> one thing at a time is in many cases better than one long check.

The generated code is in both cases the same.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors