From: David Gibson <david@gibson.dropbear.id.au>
To: Hugh Dickins <hugh@veritas.com>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 2/5] ppc64: make high hugepage areas preempt safe
Date: Wed, 1 Nov 2006 14:42:00 +1100 [thread overview]
Message-ID: <20061101034200.GC7220@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0610311839480.26470@blonde.wat.veritas.com>
On Tue, Oct 31, 2006 at 06:40:39PM +0000, Hugh Dickins wrote:
> Checking source for other get_paca()->field preemption dangers found that
> open_high_hpage_areas does a structure copy into its paca while preemption
> is enabled: unsafe however gcc accomplishes it. Just remove that copy:
> it's done safely afterwards by on_each_cpu, as in open_low_hpage_areas.
Oops, when I fixed the other problems with the PACA loading here, I
guess I missed this redundant assignment.
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
Acked-by: David Gibson <dwg@au1.ibm.com>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2006-11-01 3:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-31 18:39 [PATCH 1/5] ppc64: make current preempt safe Hugh Dickins
2006-10-31 18:40 ` [PATCH 2/5] ppc64: make high hugepage areas " Hugh Dickins
2006-11-01 3:42 ` David Gibson [this message]
2006-10-31 18:41 ` [PATCH 3/5] ppc64: make mmiowb's io_sync " Hugh Dickins
2006-10-31 18:43 ` [PATCH 4/5] ppc64: make soft_enabled irqs " Hugh Dickins
2006-11-10 9:18 ` Paul Mackerras
2006-11-10 21:32 ` Hugh Dickins
2006-10-31 18:44 ` [PATCH 5/5] ppc64: support CONFIG_DEBUG_PREEMPT Hugh Dickins
2007-02-25 19:04 ` [PATCH] include stddef.h in asm-powerpc/current.h to get definition of offsetof Olaf Hering
2007-02-26 11:34 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061101034200.GC7220@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=hugh@veritas.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.