All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ftp.linux.org.uk>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC, PATCH] dont insert sockets/pipes dentries into dentry_hashtable.
Date: Wed, 1 Nov 2006 08:42:34 +0000	[thread overview]
Message-ID: <20061101084234.GT29920@ftp.linux.org.uk> (raw)
In-Reply-To: <20061101083811.GS29920@ftp.linux.org.uk>

On Wed, Nov 01, 2006 at 08:38:11AM +0000, Al Viro wrote:
> On Wed, Nov 01, 2006 at 09:21:06AM +0100, Eric Dumazet wrote:
> 
> > And " (deleted)" is correctly added to deleted files.
> 
> The hell it will.
> 
> touch a
> touch b
> exec 5<a
> mv b a
> ls -l /proc/$$/fd/5
> 
> With your patch and without it, please.

While we are at it,

touch a
rm a
touch a
ls -l /proc/self/fd/0 <a

With and without your patch.  Note that you never remove DCACHE_DELETED
after you've set it.

  reply	other threads:[~2006-11-01  8:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-24 14:17 [PATCH] fix integer overflow in H-TCP congestion control Gavin McCullagh
2006-10-24 22:30 ` David Miller
2006-10-25  8:47   ` Gavin McCullagh
2006-10-26  6:06     ` David Miller
2006-10-31 18:48       ` [RFC, PATCH] dont insert sockets/pipes dentries into dentry_hashtable Eric Dumazet
2006-11-01  7:19         ` David Miller
2006-11-01  8:21           ` Eric Dumazet
2006-11-01  8:34             ` David Miller
2006-11-01  8:38             ` Al Viro
2006-11-01  8:42               ` Al Viro [this message]
2006-11-01  9:04               ` Eric Dumazet
2006-11-01 13:54           ` Eric Dumazet
2006-11-22 17:53         ` [PATCH] [DCACHE] : avoid RCU for never hashed dentries Eric Dumazet
2006-11-22 18:00         ` [PATCH] [NET] dont insert socket dentries into dentry_hashtable Eric Dumazet
2006-11-28 23:35           ` David Miller
2006-11-29  0:13             ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061101084234.GT29920@ftp.linux.org.uk \
    --to=viro@ftp.linux.org.uk \
    --cc=dada1@cosmosbay.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.