From: Randy Dunlap <randy.dunlap@oracle.com>
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@osdl.org>,
billm@suburbia.net
Subject: Re: [PATCH] bail out in mathemu if __copy_to_user fails
Date: Wed, 1 Nov 2006 15:14:52 -0800 [thread overview]
Message-ID: <20061101151452.0a1f3a96.randy.dunlap@oracle.com> (raw)
In-Reply-To: <200611020003.16424.jesper.juhl@gmail.com>
On Thu, 2 Nov 2006 00:03:16 +0100 Jesper Juhl wrote:
> I believe we should check the return value of
> __copy_to_user in math-emu/fpu_entry.c and bail out of save_i387_soft() if
> it fails.
> This patch does that.
>
> This also kills the warning :
> arch/i386/math-emu/fpu_entry.c:745: warning: ignoring return value of `__copy_to_user', declared with attribute warn_unused_result
http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19-rc4/2.6.19-rc4-mm1/broken-out/x86_64-mm-i386-mathemu-must-check.patch
> Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
> ---
>
> diff --git a/arch/i386/math-emu/fpu_entry.c b/arch/i386/math-emu/fpu_entry.c
> index d93f16e..ddf8fa3 100644
> --- a/arch/i386/math-emu/fpu_entry.c
> +++ b/arch/i386/math-emu/fpu_entry.c
> @@ -742,7 +742,8 @@ #ifdef PECULIAR_486
> S387->fcs &= ~0xf8000000;
> S387->fos |= 0xffff0000;
> #endif /* PECULIAR_486 */
> - __copy_to_user(d, &S387->cwd, 7*4);
> + if (__copy_to_user(d, &S387->cwd, 7*4))
> + return -1;
> RE_ENTRANT_CHECK_ON;
>
> d += 7*4;
---
~Randy
next prev parent reply other threads:[~2006-11-01 23:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-01 23:03 [PATCH] bail out in mathemu if __copy_to_user fails Jesper Juhl
2006-11-01 23:14 ` Randy Dunlap [this message]
2006-11-01 23:23 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061101151452.0a1f3a96.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=billm@suburbia.net \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.