All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ryan Harper <ryanh@us.ibm.com>
To: xen-devel@lists.xensource.com
Subject: [PATCH] xm-test: don't export RD_PATH into TENV
Date: Wed, 1 Nov 2006 16:59:49 -0600	[thread overview]
Message-ID: <20061101225949.GP12095@us.ibm.com> (raw)

xm-test currently exports the RD_PATH value into the environment which
prevents one from providing the value when running a test.  Without this
patch, one has to re-run ./autogen && ./configure with RD_PATH defined
to change the RD_PATH value that is used.

Additionally, the current getRdPath() implementation already uses the
the value that was being exported.  In short, exporting the value is not
needed unless one wants to override the default value.

With the patch, the following now works:

% cp xm-test/ramdisk/initrd.img /boot
% cd xm-test/tests/create
% RD_PATH=/boot TEST_VERBOSE=1 make TESTS=01_create_basic_pos.test check


-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
(512) 838-9253   T/L: 678-9253
ryanh@us.ibm.com


diffstat output:
 configure.ac |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

Signed-off-by: Ryan Harper <ryanh@us.ibm.com>
---
fix xm-test configure.ac to not define RD_PATH which prevented env override

diff -r 2db4388fecb9 tools/xm-test/configure.ac
--- a/tools/xm-test/configure.ac	Tue Oct 31 16:42:46 2006 +0000
+++ b/tools/xm-test/configure.ac	Tue Oct 31 15:43:13 2006 -0600
@@ -11,11 +11,10 @@ AC_PROG_CC
 #AC_PROG_INSTALL
 AC_CHECK_PROG([LILO],	lilo,	lilo,	"no",	[$PATH])
 
-# Right now, we can assume that the lib/ and ramdisk/ directories
-# are two levels above the tests
+# Right now, we can assume that the lib/ directory
+# is two levels above the tests
 TESTLIB=../../lib
-RD_PATH=../../ramdisk
-TENV="PYTHONPATH=$PYTHONPATH:$TESTLIB RD_PATH=$RD_PATH"
+TENV="PYTHONPATH=$PYTHONPATH:$TESTLIB"
 
 AC_ARG_ENABLE(hvm-support,
 	[[  --enable-hvm-support           enable hardware virtual machine assist]],

             reply	other threads:[~2006-11-01 22:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-01 22:59 Ryan Harper [this message]
2006-11-02 23:06 ` [PATCH] xm-test: don't export RD_PATH into TENV Ewan Mellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061101225949.GP12095@us.ibm.com \
    --to=ryanh@us.ibm.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.