From: Magnus Damm <magnus@valinux.co.jp>
To: linux-kernel@vger.kernel.org
Cc: Mel Gorman <mel@csn.ul.ie>, Vivek Goyal <vgoyal@in.ibm.com>,
Andi Kleen <ak@muc.de>,
magnus.damm@gmail.com, fastboot@lists.osdl.org,
Magnus Damm <magnus@valinux.co.jp>
Subject: [PATCH] x86_64: setup saved_max_pfn correctly (kdump)
Date: Thu, 02 Nov 2006 22:19:34 +0900 [thread overview]
Message-ID: <20061102131934.24684.93195.sendpatchset@localhost> (raw)
x86_64: setup saved_max_pfn correctly
2.6.19-rc4 has broken CONFIG_CRASH_DUMP support on x86_64. It is impossible
to read out the kernel contents from /proc/vmcore because saved_max_pfn is set
to zero instead of the max_pfn value before the user map is setup.
This happens because saved_max_pfn is initialized at parse_early_param() time,
and at this time no active regions have been registered. save_max_pfn is setup
from e820_end_of_ram(), more exact find_max_pfn_with_active_regions() which
returns 0 because no regions exist.
This patch fixes this by registering before and removing after the call
to e820_end_of_ram().
Signed-off-by: Magnus Damm <magnus@valinux.co.jp>
---
Applies to 2.6.19-rc4.
arch/x86_64/kernel/e820.c | 2 ++
1 file changed, 2 insertions(+)
--- 0002/arch/x86_64/kernel/e820.c
+++ work/arch/x86_64/kernel/e820.c 2006-11-02 21:37:19.000000000 +0900
@@ -594,7 +594,9 @@ static int __init parse_memmap_opt(char
* size before original memory map is
* reset.
*/
+ e820_register_active_regions(0, 0, -1UL);
saved_max_pfn = e820_end_of_ram();
+ remove_all_active_ranges();
#endif
end_pfn_map = 0;
e820.nr_map = 0;
next reply other threads:[~2006-11-02 13:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-02 13:19 Magnus Damm [this message]
2006-11-02 14:28 ` [PATCH] x86_64: setup saved_max_pfn correctly (kdump) Vivek Goyal
2006-11-02 17:40 ` Magnus Damm
2006-11-02 18:07 ` Vivek Goyal
2006-11-02 16:08 ` Mel Gorman
2006-11-02 18:05 ` Magnus Damm
2006-11-02 18:20 ` Vivek Goyal
2006-11-02 18:28 ` Magnus Damm
2006-11-02 22:41 ` Mel Gorman
2006-11-02 17:40 ` Andi Kleen
2006-11-02 18:20 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061102131934.24684.93195.sendpatchset@localhost \
--to=magnus@valinux.co.jp \
--cc=ak@muc.de \
--cc=fastboot@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mel@csn.ul.ie \
--cc=vgoyal@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.